-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add math/base/special/roundnf
#9389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Amansingh0807
wants to merge
15
commits into
stdlib-js:develop
Choose a base branch
from
Amansingh0807:feat-math-base-special-roundnf
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,583
−0
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
54a0638
feat: add math/base/special/roundnf
Amansingh0807 763596a
fix: correct float32 doctest values and lint errors in roundnf
Amansingh0807 153d4e9
fixes the Lint errors
Amansingh0807 ff1cfab
fixes the Lint errors
Amansingh0807 15255de
fix: resolve all CI errors - float32 precision, lint fixes, and N-API…
Amansingh0807 6737724
fix: resolve lint errors in test.native.js
Amansingh0807 8a020f2
refactor: use standard N-API pattern matching ldexpf convention
Amansingh0807 07c8f39
test: add edge case tests for n=±Infinity and extreme exponent values
Amansingh0807 2df69c1
docs: fix examples
anandkaranubc e80d5d6
fix: use correct `f32` emulation
anandkaranubc dd9e666
docs: fix examples
anandkaranubc 6271ce2
docs: fix examples
anandkaranubc 8669756
chore: change the order of type casting
anandkaranubc fef58ac
Fix roundnf: address PR review comments with ulpdiff testing and docu…
Amansingh0807 c3318fb
Fix roundnf native tests: remove NaN/Infinity tests for n parameter
Amansingh0807 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
214 changes: 214 additions & 0 deletions
214
lib/node_modules/@stdlib/math/base/special/roundnf/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,214 @@ | ||
| <!-- | ||
|
|
||
| @license Apache-2.0 | ||
|
|
||
| Copyright (c) 2025 The Stdlib Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
|
|
||
| --> | ||
|
|
||
| # roundnf | ||
|
|
||
| > Round a single-precision floating-point number to the nearest multiple of 10^n. | ||
|
|
||
| <section class="usage"> | ||
|
|
||
| ## Usage | ||
|
|
||
| ```javascript | ||
| var roundnf = require( '@stdlib/math/base/special/roundnf' ); | ||
| ``` | ||
|
|
||
| #### roundnf( x, n ) | ||
|
|
||
| Rounds a single-precision floating-point number to the nearest multiple of `10^n`. | ||
|
|
||
| ```javascript | ||
| // Round a value to 2 decimal places: | ||
| var v = roundnf( 3.1415927410125732, -2 ); | ||
| // returns ~3.14 | ||
|
|
||
| // If n = 0, `roundnf` behaves like `roundf`: | ||
| v = roundnf( 3.1415927410125732, 0 ); | ||
| // returns 3.0 | ||
|
|
||
| // Round a value to the nearest thousand: | ||
| v = roundnf( 12368.0, 3 ); | ||
| // returns ~12000.0 | ||
| ``` | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.usage --> | ||
|
|
||
| <section class="notes"> | ||
|
|
||
| ## Notes | ||
|
|
||
| - When operating on [floating-point numbers][ieee754] in bases other than `2`, rounding to specified digits can be **inexact**. For example, | ||
|
|
||
| ```javascript | ||
| var x = 0.2 + 0.1; | ||
| // returns 0.30000000000000004 | ||
|
|
||
| // Should round to 0.3... | ||
| var v = roundnf( x, -16 ); | ||
| // returns 0.30000001192092896 | ||
| ``` | ||
|
|
||
| - Ties are rounded toward positive infinity. | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.notes --> | ||
|
|
||
| <section class="examples"> | ||
|
|
||
| ## Examples | ||
|
|
||
| <!-- eslint no-undef: "error" --> | ||
|
|
||
| ```javascript | ||
| var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); | ||
| var uniform = require( '@stdlib/random/array/uniform' ); | ||
| var logEachMap = require( '@stdlib/console/log-each-map' ); | ||
| var roundnf = require( '@stdlib/math/base/special/roundnf' ); | ||
|
|
||
| var x = uniform( 100, -50.0, 50.0, { | ||
| 'dtype': 'float32' | ||
| }); | ||
|
|
||
| var n = discreteUniform( 100, -5, 0, { | ||
| 'dtype': 'int32' | ||
| }); | ||
|
|
||
| logEachMap( 'x: %0.8f. Number of decimals: %d. Rounded: %0.8f', x, n, roundnf ); | ||
| ``` | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.examples --> | ||
|
|
||
| <!-- C interface documentation. --> | ||
|
|
||
| * * * | ||
|
|
||
| <section class="c"> | ||
|
|
||
| ## C APIs | ||
|
|
||
| <!-- Section to include introductory text. Make sure to keep an empty line after the intro `section` element and another before the `/section` close. --> | ||
|
|
||
| <section class="intro"> | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.intro --> | ||
|
|
||
| <!-- C usage documentation. --> | ||
|
|
||
| <section class="usage"> | ||
|
|
||
| ### Usage | ||
|
|
||
| ```c | ||
| #include "stdlib/math/base/special/roundnf.h" | ||
| ``` | ||
|
|
||
| #### stdlib_base_roundnf( x, n ) | ||
|
|
||
| Rounds a single-precision floating-point number to the nearest multiple of `10^n`. | ||
|
|
||
| ```c | ||
| // Round a value to 2 decimal places: | ||
| float y = stdlib_base_roundnf( 3.14159f, -2 ); | ||
| // returns ~3.14f | ||
|
|
||
| // If n = 0, `roundnf` behaves like `roundf`: | ||
| y = stdlib_base_roundnf( 3.14159f, 0 ); | ||
| // returns 3.0f | ||
| ``` | ||
|
|
||
| The function accepts the following arguments: | ||
|
|
||
| - **x**: `[in] float` input value. | ||
| - **n**: `[in] int32_t` integer power of 10. | ||
|
|
||
| ```c | ||
| float stdlib_base_roundnf( const float x, const int32_t n ); | ||
| ``` | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.usage --> | ||
|
|
||
| <!-- C API usage notes. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> | ||
|
|
||
| <section class="notes"> | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.notes --> | ||
|
|
||
| <!-- C API usage examples. --> | ||
|
|
||
| <section class="examples"> | ||
|
|
||
| ### Examples | ||
|
|
||
| ```c | ||
| #include "stdlib/math/base/special/roundnf.h" | ||
| #include <stdio.h> | ||
|
|
||
| int main( void ) { | ||
| const float x[] = { 3.14f, -3.14f, 0.0f, 0.0f/0.0f }; | ||
|
|
||
| float y; | ||
| int i; | ||
| for ( i = 0; i < 4; i++ ) { | ||
| y = stdlib_base_roundnf( x[ i ], -2 ); | ||
| printf( "roundnf(%f, -2) = %f\n", x[ i ], y ); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.examples --> | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.c --> | ||
|
|
||
| <!-- Section for related `stdlib` packages. Do not manually edit this section, as it is automatically populated. --> | ||
|
|
||
| <section class="related"> | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.related --> | ||
|
|
||
| <!-- Section for all links. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> | ||
|
|
||
| <section class="links"> | ||
|
|
||
| [ieee754]: https://en.wikipedia.org/wiki/IEEE_754-1985 | ||
|
|
||
| <!-- <related-links> --> | ||
|
|
||
| <!-- </related-links> --> | ||
|
|
||
| </section> | ||
|
|
||
| <!-- /.links --> |
57 changes: 57 additions & 0 deletions
57
lib/node_modules/@stdlib/math/base/special/roundnf/benchmark/benchmark.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2025 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| // MODULES // | ||
|
|
||
| var bench = require( '@stdlib/bench' ); | ||
| var uniform = require( '@stdlib/random/array/uniform' ); | ||
| var discreteUniform = require( '@stdlib/random/array/discrete-uniform' ); | ||
| var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); | ||
| var pkg = require( './../package.json' ).name; | ||
| var roundnf = require( './../lib' ); | ||
|
|
||
|
|
||
| // MAIN // | ||
|
|
||
| bench( pkg, function benchmark( b ) { | ||
| var x; | ||
| var n; | ||
| var y; | ||
| var i; | ||
|
|
||
| x = uniform( 100, -100.0, 100.0, { | ||
| 'dtype': 'float32' | ||
| }); | ||
| n = discreteUniform( 100, -5, 0 ); | ||
|
|
||
| b.tic(); | ||
| for ( i = 0; i < b.iterations; i++ ) { | ||
| y = roundnf( x[ i%x.length ], n[ i%n.length ] ); | ||
| if ( isnanf( y ) ) { | ||
| b.fail( 'should not return NaN' ); | ||
| } | ||
| } | ||
| b.toc(); | ||
| if ( isnanf( y ) ) { | ||
| b.fail( 'should not return NaN' ); | ||
| } | ||
| b.pass( 'benchmark finished' ); | ||
| b.end(); | ||
| }); |
63 changes: 63 additions & 0 deletions
63
lib/node_modules/@stdlib/math/base/special/roundnf/benchmark/benchmark.native.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2025 The Stdlib Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| // MODULES // | ||
|
|
||
| var resolve = require( 'path' ).resolve; | ||
| var bench = require( '@stdlib/bench' ); | ||
| var randu = require( '@stdlib/random/base/randu' ); | ||
| var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ); | ||
| var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); | ||
| var tryRequire = require( '@stdlib/utils/try-require' ); | ||
| var pkg = require( './../package.json' ).name; | ||
|
|
||
|
|
||
| // VARIABLES // | ||
|
|
||
| var roundnf = tryRequire( resolve( __dirname, './../lib/native.js' ) ); | ||
| var opts = { | ||
| 'skip': ( roundnf instanceof Error ) | ||
| }; | ||
|
|
||
|
|
||
| // MAIN // | ||
|
|
||
| bench( pkg+'::native', opts, function benchmark( b ) { | ||
| var x; | ||
| var n; | ||
| var y; | ||
| var i; | ||
|
|
||
| b.tic(); | ||
| for ( i = 0; i < b.iterations; i++ ) { | ||
| x = ( randu() * 100.0 ) - 50.0; | ||
| n = discreteUniform( -5, 0 ); | ||
| y = roundnf( x, n ); | ||
| if ( isnanf( y ) ) { | ||
| b.fail( 'should not return NaN' ); | ||
| } | ||
| } | ||
| b.toc(); | ||
| if ( isnanf( y ) ) { | ||
| b.fail( 'should not return NaN' ); | ||
| } | ||
| b.pass( 'benchmark finished' ); | ||
| b.end(); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here. Check https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/secf/benchmark/benchmark.js