feat: add `math/base/special/roundnf` #9389

Amansingh0807 · 2025-12-27T07:04:39Z

Resolves None

Description

What is the purpose of this pull request?

This pull request:

This PR adds math/base/special/roundnf.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

stdlib-bot · 2025-12-27T08:02:07Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/roundnf	$\color{red}269/271$ $\color{green}+2.67%$	$\color{red}22/23$ $\color{green}+5.72%$	$\color{green}2/2$ $\color{green}+0.00%$	$\color{red}269/271$ $\color{green}+2.67%$

The above coverage report was generated for the changes in this PR.

… corrections

Amansingh0807 · 2025-12-28T06:09:31Z

Hi @kgryte !!
I noticed packages like roundn and others include Python, Julia, and R benchmarks for cross-language performance comparison. Should I add these benchmarks for completeness, or are the current JS/Native benchmarks sufficient for this PR?

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

anandkaranubc

This PR needs a lot of cleanup. I think the best approach would be to go through all the comments above and the files again, and check whether it closely resembles what is being done in roundn. I have pushed a few changes, but there are still some remaining. Ping me whenever you need clarification on why certain comments and changes were made.

anandkaranubc · 2025-12-30T23:35:14Z

lib/node_modules/@stdlib/math/base/special/roundnf/lib/index.js

+* var v = roundnf( 3.141592, -2 );
+* // returns 3.140000104904175


Suggested change

* var v = roundnf( 3.141592, -2 );

* // returns 3.140000104904175

* var v = roundnf( 3.1415927410125732, -2 );

* // returns ~3.14

It’s better to use approximate return values here using ~. If you use exact return values and the implementation changes for this package or the packages it depends on, it will break the linting for these files as well.

anandkaranubc · 2025-12-30T23:36:16Z

lib/node_modules/@stdlib/math/base/special/roundnf/lib/index.js

+* var roundnf = require( '@stdlib/math/base/special/roundnf' );
+*
+* // If n = 0, `roundnf` behaves like `roundf`:
+* var v = roundnf( 3.141592, 0 );


Suggested change

* var v = roundnf( 3.141592, 0 );

* var v = roundnf( 3.1415927410125732, 0 );

Keeping the same example as above here too, for consistency.

anandkaranubc · 2025-12-30T23:38:13Z

lib/node_modules/@stdlib/math/base/special/roundnf/lib/index.js

+* @example
+* var roundnf = require( '@stdlib/math/base/special/roundnf' );


You only need to use @example once in the index.js file. For more context you can refer to the index.js in roundn.

anandkaranubc · 2025-12-30T23:39:46Z

lib/node_modules/@stdlib/math/base/special/roundnf/lib/main.js

+var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
+var isnan = require( '@stdlib/math/base/assert/is-nan' );


Suggested change

var isnanf = require( '@stdlib/math/base/assert/is-nanf' );

var isnan = require( '@stdlib/math/base/assert/is-nan' );

var isnanf = require( '@stdlib/math/base/assert/is-nanf' );

You only need the single-precision based packages here.

anandkaranubc · 2025-12-30T23:40:37Z

lib/node_modules/@stdlib/math/base/special/roundnf/lib/main.js

+var roundf = require( '@stdlib/math/base/special/roundf' );
+var powf = require( '@stdlib/math/base/special/powf' );
+var absf = require( '@stdlib/math/base/special/absf' );
+var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );


Suggested change

var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );

var f32 = require( '@stdlib/number/float64/base/to-float32' );

anandkaranubc · 2025-12-31T00:01:31Z

lib/node_modules/@stdlib/math/base/special/roundnf/lib/native.js

+* @example
+* var v = roundnf( 3.141592, -2 );
+* // returns 3.140000104904175
+*
+* @example
+* var v = roundnf( 3.141592, 0 );
+* // returns 3.0
+*
+* @example
+* var v = roundnf( 1234.56, 2 );
+* // returns 1200.0
+*/


Suggested change

* @example

* var v = roundnf( 3.141592, -2 );

* // returns 3.140000104904175

*

* @example

* var v = roundnf( 3.141592, 0 );

* // returns 3.0

*

* @example

* var v = roundnf( 1234.56, 2 );

* // returns 1200.0

*/

* @example

* // Round a value to 2 decimal places:

* var v = roundnf( 3.1415927410125732, -2 );

* // returns ~3.14

*

* @example

* // If n = 0, `roundnf` behaves like `roundf`:

* var v = roundnf( 3.1415927410125732, 0 );

* // returns 3.0

*

* @example

* // Round a value to the nearest thousand:

* var v = roundnf( 12368.0, 3 );

* // returns ~12000.0

*/

You have to folllow the same example structure as main.js

anandkaranubc · 2025-12-31T00:19:55Z

lib/node_modules/@stdlib/math/base/special/roundnf/test/test.js

@Amansingh0807 This entire file needs revision. I would suggest reviewing https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/roundn/test/test.js. Copy over all the tests from that file and modify them accordingly for this package. It seems like you are missing several important tests.

Also, that file uses EPS-based thresholds. Can you use var ulpdiff = require( '@stdlib/number/float32/base/ulp-difference' ); here instead?

The same applies to test.native.js as well.

anandkaranubc · 2025-12-31T00:22:32Z

lib/node_modules/@stdlib/math/base/special/roundnf/examples/index.js

Can you refactor this as well, following what's done in https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/roundn/examples/index.js?

anandkaranubc · 2025-12-31T00:24:13Z

lib/node_modules/@stdlib/math/base/special/roundnf/benchmark/c/native/benchmark.c

This doesn't seem the way we do C benchmarking. You will need to refer to what was done in https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/secf/benchmark/c/native/benchmark.c

anandkaranubc · 2025-12-31T00:24:58Z

lib/node_modules/@stdlib/math/base/special/roundnf/benchmark/benchmark.js

Same comment here. Check https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/secf/benchmark/benchmark.js

anandkaranubc · 2025-12-31T09:16:46Z

@Amansingh0807 I just finished reviewing #4881, and the expected changes here are very similar to the changes I recently made in that PR. The best way to update this PR would be to go through that one and follow the same commits.

…mentation updates

Amansingh0807 · 2025-12-31T17:01:24Z

Hi @anandkaranubc,
Thanks for the review! I've made the necessary changes as per the reviews.
Ready for review!

feat: add math/base/special/roundnf

54a0638

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 27, 2025

Amansingh0807 marked this pull request as draft December 27, 2025 07:06

stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 27, 2025

Amansingh0807 added 3 commits December 27, 2025 12:50

fix: correct float32 doctest values and lint errors in roundnf

763596a

fixes the Lint errors

153d4e9

fixes the Lint errors

ff1cfab

fix: resolve all CI errors - float32 precision, lint fixes, and N-API…

15255de

… corrections

Amansingh0807 force-pushed the feat-math-base-special-roundnf branch from 4a794b6 to 15255de Compare December 27, 2025 08:11

fix: resolve lint errors in test.native.js

6737724

Amansingh0807 marked this pull request as ready for review December 27, 2025 08:27

stdlib-bot added the Needs Review A pull request which needs code review. label Dec 27, 2025

Amansingh0807 added 2 commits December 27, 2025 14:12

refactor: use standard N-API pattern matching ldexpf convention

8a020f2

test: add edge case tests for n=±Infinity and extreme exponent values

07c8f39

anandkaranubc self-requested a review December 30, 2025 23:27

anandkaranubc added 5 commits December 30, 2025 15:58

anandkaranubc requested changes Dec 31, 2025

View reviewed changes

anandkaranubc added JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 31, 2025

Fix roundnf: address PR review comments with ulpdiff testing and docu…

fef58ac

…mentation updates

Fix roundnf native tests: remove NaN/Infinity tests for n parameter

c3318fb

		* var v = roundnf( 3.141592, -2 );
		* // returns 3.140000104904175

	* var v = roundnf( 3.141592, 0 );
	* var v = roundnf( 3.1415927410125732, 0 );

		* @example
		* var roundnf = require( '@stdlib/math/base/special/roundnf' );

		var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
		var isnan = require( '@stdlib/math/base/assert/is-nan' );

	var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
	var f32 = require( '@stdlib/number/float64/base/to-float32' );

Uh oh!

feat: add math/base/special/roundnf #9389

Are you sure you want to change the base?

feat: add math/base/special/roundnf #9389

Conversation

Amansingh0807 commented Dec 27, 2025

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Amansingh0807 commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anandkaranubc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anandkaranubc commented Dec 31, 2025

Uh oh!

Amansingh0807 commented Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `math/base/special/roundnf` #9389

feat: add `math/base/special/roundnf` #9389

stdlib-bot commented Dec 27, 2025 •

edited

Loading

Amansingh0807 commented Dec 28, 2025 •

edited

Loading