Skip to content

Conversation

@dominikl
Copy link
Member

@dominikl dominikl commented Oct 9, 2025

Trying to resolve version conflict with omero-zarr-pixel-buffer (#11 will use jackson libs version 2.20.0); omero-server comes with 2.14.2, which I tracked down to ome-common-java (omero-server -> bioformats -> ome-common-java), although it's actually not used in the server or in bioformats

<version>2.14.2</version>

Could this be bumped to 2.20.0? As far as I can see it's used in bioformats2raw/raw2ometiff, image-region microservice and Insight: https://github.com/search?q=org%3Aome%20import%20com.fasterxml.jackson&type=code . It should be backwards compatible with 2.14, so I wouldn't expect any changes needed.

@dominikl dominikl closed this Oct 14, 2025
@dominikl dominikl reopened this Oct 14, 2025
@melissalinkert
Copy link
Member

@dominikl, is this now ready for review or were there any more commits planned?

@dominikl
Copy link
Member Author

Yes, ready for review. Just wasn't sure who to add as reviewer.

Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any particular objection to this and builds have continued to pass with this included (e.g. https://bf-testing-results.s3.amazonaws.com/2025/2025-10-21/build-status.log). Requesting review from @sbesson too though, as I don't have a good sense of what the impact is in OMERO (if any).

@sbesson
Copy link
Member

sbesson commented Oct 24, 2025

I also don't have any objection per se on the version bump but it might be worth discussing the intent and the expectations. Having reviewed the history in the scope of this repository:

The latter points makes me consider whether managing the jackson version at the level of this component is a viable approach. In some ways, this strategy is inheriting the concepts of a Maven Bill of Materials. However, this component is not a BOM and the OME Java stack is currently not architected to adhere to such principles. The opposite perspective is that downstream repositories should be responsible for declaring their dependencies and versions, overriding versions declared by upstream components as needed. I would propose to us an upcoming Formats meeting so that we can review and discuss the problem we are trying to solve and evaluate the various strategies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants