-
Notifications
You must be signed in to change notification settings - Fork 970
docs(migration): update changed components #5655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -448,6 +448,31 @@ This change affects the following components: `Modal`, `Popover`, `Slideover`, ` | |
| This change affects the following components: `Modal`, `Slideover`. | ||
| :: | ||
|
|
||
| - The `prevent-close` prop in `Modal` and `Slideover` has been removed in favor of the `dismissible` prop that takes a boolean value: | ||
| ```diff | ||
| <template> | ||
| - <UModal prevent-close /> | ||
| + <UModal :dismissible="true" /> | ||
| </template> | ||
| ``` | ||
|
|
||
| - The `v-model` directive in `Pagination` has been renamed to `v-model:page` to control current page: | ||
|
|
||
| ```diff | ||
| <template> | ||
| - <UPagination v-model="page" /> | ||
| + <UPagination v-model:page="page" /> | ||
| </template> | ||
| ``` | ||
|
|
||
| - The `change` event in `Select`, `SelectMenu` and `RadioGroup` now emits the native `change` event, not the new chnage value, which is now emitted in the `update:modelValue` event: | ||
|
|
||
| ```diff | ||
| <template></template> | ||
| - <USelectMenu v-model="country" :items="countries" @change="console.log(newVal)" /> | ||
| + <USelectMenu v-model="country" :items="countries" @update:modelValue="console.log(newVal)" /> | ||
| ``` | ||
|
Comment on lines
+468
to
+474
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you mean by this? π€ The
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed that in v2, I used to use the
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see, I don't think it's necessary to mention though the recommended way was always
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's what I thought too though since the behavior changed, I felt it would be worth mentioned, as it can break functionality in certain cases. Anyhow, tell me your final thoughts so that I can adjust, also should I make the same changes on v4 branch on a sperate PR?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok let's keep it this way. I added a suggestion but once it's done it would be nice to do this on |
||
|
|
||
| ### Changed composables | ||
|
|
||
| - The `useToast()` composable `timeout` prop has been renamed to `duration`: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.