-
Notifications
You must be signed in to change notification settings - Fork 968
docs(migration): update changed components #5655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Conversation
commit: |
| - The `change` event in `Select`, `SelectMenu` and `RadioGroup` now emits the native `change` event, not the new chnage value, which is now emitted in the `update:modelValue` event: | ||
|
|
||
| ```diff | ||
| <template></template> | ||
| - <USelectMenu v-model="country" :items="countries" @change="console.log(newVal)" /> | ||
| + <USelectMenu v-model="country" :items="countries" @update:modelValue="console.log(newVal)" /> | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by this? 🤔 The @change event still exists in v3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that in v2, I used to use the @change event to capture the new selected value. It used to give the new value, same behavior as @update:model-value event. But in v3, the @change event returns the native HTML change event, so I had to use @update:model-value instead to keep the same behavior.
|
This PR targets |
I'm not sure I'm following you well, but in my work, we migrated v2 to v3. We yet to migrate to v4. I just noticed that the migration guide is yet to be fully completed so I decided to add some of the breaking changes I noticed. |
|
What I meant is the migration guide on |
So should I apply the same changes on v4 and open a new PR or how should this "backport" work? |
Updated the migration page by adding some of the changes that I noticed and are not documented
📚 Description
prevent-closeand the newdismissibleprop forUModalandUSlideover.v-modelchange inUPagination(v-model:pageinstead ofv-model).USelect,USelectMenu, andURadioGroupregarding the new change event behavior and the shift to usingupdate:model-valuefor receiving the selected value.📝 Checklist