⚒️ Migrate account chooser for sharing from flex adapter to composables#5914
Merged
AndyScherzinger merged 3 commits intomasterfrom Mar 3, 2026
Merged
⚒️ Migrate account chooser for sharing from flex adapter to composables#5914AndyScherzinger merged 3 commits intomasterfrom
AndyScherzinger merged 3 commits intomasterfrom
Conversation
AndyScherzinger
added
3. to review
AndyScherzinger
changed the title
16 tasks
AndyScherzinger
force-pushed
the
chore/noid/flexMig1
branch
from
d6eb57d to
600ad4a
Compare
AndyScherzinger
changed the title
AndyScherzinger
force-pushed
the
chore/noid/flexMig1
branch
from
600ad4a to
5ee164b
Compare
alperozturk96
requested changes
Mar 2, 2026
app/src/main/java/com/nextcloud/talk/ui/dialog/viewmodels/ChooseAccountShareToViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/talk/ui/chooseaccount/ChooseAccountShareToViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/talk/ui/chooseaccount/ChooseAccountShareToViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/talk/ui/chooseaccount/ChooseAccountShareToViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/talk/ui/dialog/ChooseAccountShareToDialogCompose.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/talk/ui/dialog/ChooseAccountShareToDialogFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/talk/ui/chooseaccount/ChooseAccountShareToDialogFragment.kt
Show resolved
Hide resolved
AndyScherzinger
force-pushed
the
chore/noid/flexMig1
branch
from
5ee164b to
0cffadc
Compare
alperozturk96
approved these changes
Mar 2, 2026
Contributor
alperozturk96
left a comment
alperozturk96
left a comment
There was a problem hiding this comment.
Codewise looks good thank you 👍
AndyScherzinger
force-pushed
the
chore/noid/flexMig1
branch
2 times, most recently
from
8959889 to
115575f
Compare
6 tasks
sowjanyakch
approved these changes
Mar 3, 2026
…menting mvvm Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
chore/noid/flexMig1
branch
from
115575f to
20d92b2
Compare
Contributor
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5914.apk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an easier review I kept the commits split: migrate away from flex adapter, migrate to composables
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x