⚒️ Migrate ConversationInfoActivity, Participants and MentionAutoComplete #5921
Merged
AndyScherzinger merged 5 commits intomasterfrom Mar 4, 2026
Merged
⚒️ Migrate ConversationInfoActivity, Participants and MentionAutoComplete #5921AndyScherzinger merged 5 commits intomasterfrom
AndyScherzinger merged 5 commits intomasterfrom
Conversation
AndyScherzinger
added
3. to review
AndyScherzinger
changed the title
AndyScherzinger
force-pushed
the
chore/noid/flexMig2
branch
3 times, most recently
from
dbccd48 to
047c768
Compare
16 tasks
alperozturk96
requested changes
Mar 3, 2026
app/src/main/java/com/nextcloud/talk/conversationinfo/ConversationInfoActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/talk/conversationinfo/ParticipantItemAdapter.kt
Show resolved
Hide resolved
AndyScherzinger
force-pushed
the
chore/noid/flexMig2
branch
2 times, most recently
from
61510c4 to
4b3fd93
Compare
alperozturk96
approved these changes
Mar 4, 2026
Contributor
alperozturk96
left a comment
alperozturk96
left a comment
There was a problem hiding this comment.
Codewise looks good.
…Complete away from flexible adapter Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> Co-authored-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de> Co-authored-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
chore/noid/flexMig2
branch
from
e6f9731 to
c01620a
Compare
Contributor
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5921.apk |
mahibi
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…away from flexible adapter
I tested @ mentions in message input as well as participant lists in the conversation info for users, guests and groups with status / emoji status and in a video call.
Also since this already touches some classes, kept it at that while still doing some renamings. Also didn't touch the packaging while this might need some cleanup in the future yet isn't worse than before (hinting to the mix of autocomplete classes and participant links)
Also some handling extraction in initViewStateObserver in the activity to make detekt happy again... 🙄
This is a follow-up to #5914
🚧 TODO
🏁 Checklist
/backport to stable-xx.x