convert : refactor rope scaling handling #18013
Merged
+88
−269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ggerganov
approved these changes
Dec 14, 2025
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
Confirming that gpt-oss converts correctly. Will take a look at the rest of the changes, but probably won't be able to give much additional feedback on the python code.
ngxson
reviewed
Dec 14, 2025
| self.model_name = model_name | ||
| self.dir_model_card = dir_model # overridden in convert_lora_to_gguf.py | ||
|
|
||
| # Ensure "rope_theta" and "rope_type" is mirrored in rope_parameters |
Collaborator
There was a problem hiding this comment.
I think it probably better to extract this into a new method called load_rope_params
Collaborator
Author
There was a problem hiding this comment.
I considered it, but it got a little awkward as a static method and not much sense as a regular method.
ngxson
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle rope scaling in
set_gguf_parametersto deduplicate code and support the newrope_parameters(whererope_thetaalso has moved) introduced in huggingface/transformers#39847Obsoletes #18008