convert : fix gpt-oss #18008
Closed
convert : fix gpt-oss #18008
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CISC
reviewed
Dec 13, 2025
Co-authored-by: Sigbjørn Skjæret <[email protected]>
CISC
reviewed
Dec 13, 2025
| assert rope_type == "yarn", f"GPT-OSS only supports yarn rope scaling, got {rope_type}" | ||
| self.gguf_writer.add_rope_scaling_type(gguf.RopeScalingType.YARN) | ||
| self.gguf_writer.add_rope_scaling_factor(rope_scaling["factor"]) | ||
| self.gguf_writer.add_rope_freq_base(rope_scaling.get("rope_theta")) |
Collaborator
There was a problem hiding this comment.
Suggested change
| self.gguf_writer.add_rope_freq_base(rope_scaling.get("rope_theta")) | |
| self.gguf_writer.add_rope_freq_base(rope_scaling.get("rope_theta", hparams.get("rope_theta"))) |
So, they moved this in v5, we need to check both places.
Collaborator
|
I can make a follow up if you want, this needs to be fixed quite a few places. |
Collaborator
It's a fairly big refactor actually, will obsolete this PR. |
Member
Author
|
Superseded by #18013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix conversion of https://huggingface.co/openai/gpt-oss-20b