Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/testflight.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
push:
branches:
- main
- alwx/ci/macos-tahoe-cl-runners

pull_request:
paths:
Comment on lines +6 to 9
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The testflight.yml workflow is configured to trigger on pushes to the feature branch alwx/ci/macos-tahoe-cl-runners, which will cause unintended uploads to production TestFlight.
Severity: HIGH

Suggested Fix

Remove the feature branch alwx/ci/macos-tahoe-cl-runners from the list of branches under the push trigger in the .github/workflows/testflight.yml file. Workflows that deploy to production environments should typically only be triggered by pushes to main or release branches.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/testflight.yml#L6-L9

Potential issue: The `testflight.yml` workflow includes the feature branch
`alwx/ci/macos-tahoe-cl-runners` in its `push` triggers. This configuration will cause a
new build to be uploaded to Apple's production TestFlight environment every time a
commit is pushed to this branch. This is likely unintentional, as feature branches are
typically used for development and review, not for triggering production deployments.
This action will consume production build numbers from `${{ github.run_number }}` and
could cause confusion for testers by distributing development builds.

Expand All @@ -14,7 +15,7 @@ jobs:

upload_to_testflight:
name: Build and Upload React Native Sample to Testflight
runs-on: ["ghcr.io/cirruslabs/macos-sequoia-xcode:16.4", "runner_group_id:12"]
runs-on: ["ghcr.io/cirruslabs/macos-tahoe-xcode:26.2.0", "runner_group_id:12"]
needs: [diff_check]
if: ${{ needs.diff_check.outputs.skip_ci != 'true' }}
steps:
Expand Down Expand Up @@ -62,6 +63,10 @@ jobs:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
SENTRY_LOG_LEVEL: DEBUG
SENTRY_CLI_EXTRA_ARGS: "--force-foreground"
# Fix for Xcode 26+ with MetalToolchain: use default Xcode toolchain to avoid
# missing Swift compatibility libraries (swiftCompatibility56, etc.)
# See: https://github.com/actions/runner-images/issues/13135
TOOLCHAINS: com.apple.dt.toolchain.XcodeDefault
run: |
bundle exec fastlane ios build_react_native_sample
bundle exec fastlane ios upload_react_native_sample_to_testflight
Expand Down
Loading