Use Tahoe Cirrus Labs runner for Testflight builds#5675
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c7f264b | 434.98 ms | 452.96 ms | 17.98 ms |
| 5691430+dirty | 433.98 ms | 478.49 ms | 44.51 ms |
| 86584b7+dirty | 463.83 ms | 500.31 ms | 36.48 ms |
| a483f9f+dirty | 396.82 ms | 453.28 ms | 56.46 ms |
| ff5a06a+dirty | 405.97 ms | 439.24 ms | 33.27 ms |
| df1f7df+dirty | 442.64 ms | 427.16 ms | -15.48 ms |
| d1fd647+dirty | 413.02 ms | 459.72 ms | 46.70 ms |
| f17e051+dirty | 396.23 ms | 444.02 ms | 47.79 ms |
| 69602ce | 417.47 ms | 443.52 ms | 26.05 ms |
| 7be1f99 | 454.83 ms | 461.36 ms | 6.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c7f264b | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 5691430+dirty | 43.75 MiB | 48.04 MiB | 4.29 MiB |
| 86584b7+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| a483f9f+dirty | 43.75 MiB | 48.41 MiB | 4.66 MiB |
| ff5a06a+dirty | 43.75 MiB | 48.05 MiB | 4.29 MiB |
| df1f7df+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| d1fd647+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| f17e051+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
| 69602ce | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 7be1f99 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9b50d32+dirty | 1216.53 ms | 1221.64 ms | 5.10 ms |
| b1579bc+dirty | 1213.76 ms | 1208.66 ms | -5.10 ms |
| 7480abe+dirty | 1220.53 ms | 1244.18 ms | 23.65 ms |
| 652f785+dirty | 1219.66 ms | 1223.62 ms | 3.96 ms |
| 73f2455+dirty | 1213.49 ms | 1211.96 ms | -1.53 ms |
| 161947d+dirty | 1203.43 ms | 1217.00 ms | 13.57 ms |
| 74979ac+dirty | 1210.49 ms | 1213.31 ms | 2.82 ms |
| c94a927+dirty | 1227.14 ms | 1239.64 ms | 12.50 ms |
| d9f44bb+dirty | 1227.85 ms | 1226.00 ms | -1.85 ms |
| df1f7df+dirty | 1219.21 ms | 1224.28 ms | 5.07 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9b50d32+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| b1579bc+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| 7480abe+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 652f785+dirty | 3.41 MiB | 4.57 MiB | 1.16 MiB |
| 73f2455+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 161947d+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
| 74979ac+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| c94a927+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
| d9f44bb+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| df1f7df+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9b50d32+dirty | 1210.36 ms | 1218.41 ms | 8.05 ms |
| b1579bc+dirty | 1223.02 ms | 1220.98 ms | -2.04 ms |
| 7480abe+dirty | 1219.84 ms | 1223.60 ms | 3.76 ms |
| 652f785+dirty | 1216.42 ms | 1212.21 ms | -4.21 ms |
| 73f2455+dirty | 1219.85 ms | 1218.29 ms | -1.56 ms |
| 161947d+dirty | 1203.45 ms | 1217.83 ms | 14.38 ms |
| 74979ac+dirty | 1212.33 ms | 1212.54 ms | 0.21 ms |
| c94a927+dirty | 1211.33 ms | 1223.31 ms | 11.97 ms |
| d9f44bb+dirty | 1205.74 ms | 1208.40 ms | 2.66 ms |
| df1f7df+dirty | 1217.00 ms | 1213.27 ms | -3.73 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9b50d32+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| b1579bc+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| 7480abe+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
| 652f785+dirty | 3.41 MiB | 4.57 MiB | 1.16 MiB |
| 73f2455+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 161947d+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
| 74979ac+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| c94a927+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
| d9f44bb+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| df1f7df+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
eec7a99 to
15de79e
Compare
f14e791 to
15de79e
Compare
|
@antonis review please |
| - alwx/ci/macos-tahoe-cl-runners | ||
|
|
||
| pull_request: | ||
| paths: |
There was a problem hiding this comment.
Bug: The testflight.yml workflow is configured to trigger on pushes to the feature branch alwx/ci/macos-tahoe-cl-runners, which will cause unintended uploads to production TestFlight.
Severity: HIGH
Suggested Fix
Remove the feature branch alwx/ci/macos-tahoe-cl-runners from the list of branches under the push trigger in the .github/workflows/testflight.yml file. Workflows that deploy to production environments should typically only be triggered by pushes to main or release branches.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/testflight.yml#L6-L9
Potential issue: The `testflight.yml` workflow includes the feature branch
`alwx/ci/macos-tahoe-cl-runners` in its `push` triggers. This configuration will cause a
new build to be uploaded to Apple's production TestFlight environment every time a
commit is pushed to this branch. This is likely unintentional, as feature branches are
typically used for development and review, not for triggering production deployments.
This action will consume production build numbers from `${{ github.run_number }}` and
could cause confusion for testers by distributing development builds.
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c9e95bd+dirty | 339.32 ms | 401.24 ms | 61.92 ms |
| 2b89ce9+dirty | 372.22 ms | 417.06 ms | 44.84 ms |
| 2f9fb30+dirty | 383.06 ms | 404.56 ms | 21.50 ms |
| f70acbf+dirty | 520.12 ms | 558.91 ms | 38.79 ms |
| 64cd15c+dirty | 488.79 ms | 483.54 ms | -5.24 ms |
| 785ffb1+dirty | 380.65 ms | 451.83 ms | 71.18 ms |
| f8d19f8+dirty | 374.17 ms | 383.40 ms | 9.23 ms |
| 1ef8a04+dirty | 450.73 ms | 482.38 ms | 31.65 ms |
| 3bd3f0d+dirty | 334.38 ms | 402.19 ms | 67.81 ms |
| 46da307+dirty | 356.62 ms | 415.02 ms | 58.40 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c9e95bd+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 2b89ce9+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 2f9fb30+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| f70acbf+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 64cd15c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 785ffb1+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| f8d19f8+dirty | 43.94 MiB | 48.91 MiB | 4.97 MiB |
| 1ef8a04+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 3bd3f0d+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 46da307+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
antonis
left a comment
There was a problem hiding this comment.
Awesome work @alwx 🙇
The testflight job is 🟢
📢 Type of change
📜 Description
v8 got merged, now Tahoe CI runners could be merged as well.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps