Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Nov 11, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #5356

📜 Description

Bump MacOS sample to macos 12.0 which is the minimum for v9

💡 Motivation and Context

Failed tests and MacOS version bump in the Apple SDK

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

itaybre and others added 22 commits September 8, 2025 15:27
# Conflicts:
#	packages/core/ios/RNSentry.mm
…wift

# Conflicts:
#	packages/core/RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj
#	packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m
#	packages/core/ios/RNSentry.mm
#	packages/core/ios/RNSentryDependencyContainer.m
#	packages/core/ios/SentrySDKWrapper.h
#	packages/core/ios/SentrySDKWrapper.m
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 11, 2025
@antonis antonis mentioned this pull request Nov 11, 2025
10 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.06 ms 1214.26 ms 0.19 ms
Size 3.41 MiB 4.63 MiB 1.21 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 385.74 ms 416.26 ms 30.52 ms
Size 43.75 MiB 48.02 MiB 4.27 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.50 ms 1212.06 ms -3.44 ms
Size 3.41 MiB 4.63 MiB 1.21 MiB

Base automatically changed from itay/frames_tracker_swift to cocoa-v9 November 11, 2025 15:41
@antonis antonis marked this pull request as ready for review November 11, 2025 15:42
@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025

The two failing/canceled tests seem to be irelevant with this PR and will be handled separately:

I believe they might be related to a recent macos-13 runner deprecation

@antonis antonis changed the title chore(sample): Bump MacOS sample to macos 12.0 chore(sample): Cocoa-v9: Bump MacOS sample to macos 12.0 Nov 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 369.85 ms 396.18 ms 26.33 ms
Size 43.94 MiB 48.85 MiB 4.91 MiB

@antonis
Copy link
Contributor Author

antonis commented Nov 12, 2025

@antonis antonis merged commit 8aea859 into cocoa-v9 Nov 13, 2025
66 of 68 checks passed
@antonis antonis deleted the antonis/cocoa-v9-macos-v12-bump branch November 13, 2025 11:00
antonis added a commit that referenced this pull request Dec 23, 2025
* chore(deps): update Cocoa SDK to v9.0.0-alpha.0

* Adds changelog

* fix: Fixes SentryScreenFrames use after being converted to Swift (#5153)

* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

---------

Co-authored-by: Antonis Lilis <[email protected]>

* Move `sentry-cocoa` `enableLogs` out of experimental (#5267)

* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

---------

Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Antonis Lilis <[email protected]>

* chore: Remove SentryFrameTracker imports (#5276)

* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

---------

Co-authored-by: Antonis Lilis <[email protected]>
Co-authored-by: Denis Andrasec <[email protected]>
Co-authored-by: Noah Martin <[email protected]>

* fix(podspec): Cocoa V9 allow any alpha version

* chore(sample): Cocoa-v9: Bump MacOS sample to macos 12.0 (#5359)

* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

---------

Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Denis Andrasec <[email protected]>
Co-authored-by: Noah Martin <[email protected]>

* chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0 (#5369)

* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

* chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0

* Bump to 15.1 due to RN 0.81.0 requirements

---------

Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Denis Andrasec <[email protected]>
Co-authored-by: Noah Martin <[email protected]>

* chore(ci): Cocoa V9: Run the full CI checks for cocoa-v9 (#5370)

* Update changelog

* Bumpt to RC1

* Remove cocoa-v9 from ci branches

* fix: Use new session replay name for hybrid SDK

* Fix rename

* chore(lint): Fixes lint issues

* Update changelog to GA

* Update changelog

* Bump minimum to 9.1.0

* Set Cocoa version to 9.1.0

---------

Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Denis Andrašec <[email protected]>
Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Noah Martin <[email protected]>
Co-authored-by: Philipp Hofmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants