Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Nov 11, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes #5461

Breaking changes:

SubPRs:

💡 Motivation and Context

See #5273

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025

Marking as Blocked while the Cocoa v9 is in Alpha

itaybre and others added 3 commits November 11, 2025 16:38
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

---------

Co-authored-by: Antonis Lilis <[email protected]>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

---------

Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Antonis Lilis <[email protected]>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

---------

Co-authored-by: Antonis Lilis <[email protected]>
Co-authored-by: Denis Andrasec <[email protected]>
Co-authored-by: Noah Martin <[email protected]>
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 11, 2025
@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025

Adding the ready-to-merge label to trigger all tests but it's not really ready to merge 😅

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 364.40 ms 403.50 ms 39.10 ms
Size 43.94 MiB 48.91 MiB 4.97 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
9aa9f9b+dirty 597.51 ms 634.22 ms 36.71 ms
0816bdc+dirty 576.86 ms 619.67 ms 42.81 ms
326e1a7+dirty 425.27 ms 425.81 ms 0.54 ms
89237d0+dirty 369.06 ms 386.56 ms 17.50 ms

App size

Revision Plain With Sentry Diff
9aa9f9b+dirty 43.94 MiB 48.90 MiB 4.96 MiB
0816bdc+dirty 43.94 MiB 48.90 MiB 4.96 MiB
326e1a7+dirty 43.94 MiB 48.90 MiB 4.96 MiB
89237d0+dirty 43.94 MiB 48.91 MiB 4.97 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 425.83 ms 462.77 ms 36.94 ms
Size 43.75 MiB 48.08 MiB 4.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
eb07ba3 470.04 ms 473.35 ms 3.31 ms
0b64753+dirty 448.67 ms 474.61 ms 25.94 ms
1c38acd+dirty 398.09 ms 409.18 ms 11.09 ms
294387d+dirty 424.30 ms 465.40 ms 41.10 ms
8d0a325+dirty 406.48 ms 415.02 ms 8.54 ms
5ee3314+dirty 415.80 ms 426.14 ms 10.34 ms
5602cc4+dirty 419.91 ms 439.52 ms 19.61 ms
59f3a84+dirty 382.16 ms 376.45 ms -5.71 ms
46e3d54+dirty 467.76 ms 487.53 ms 19.78 ms
ebf60f9+dirty 378.38 ms 405.48 ms 27.10 ms

App size

Revision Plain With Sentry Diff
eb07ba3 17.75 MiB 20.15 MiB 2.41 MiB
0b64753+dirty 17.75 MiB 19.70 MiB 1.95 MiB
1c38acd+dirty 43.75 MiB 48.08 MiB 4.33 MiB
294387d+dirty 43.75 MiB 48.04 MiB 4.29 MiB
8d0a325+dirty 43.75 MiB 48.08 MiB 4.33 MiB
5ee3314+dirty 17.75 MiB 19.70 MiB 1.95 MiB
5602cc4+dirty 43.75 MiB 48.07 MiB 4.32 MiB
59f3a84+dirty 17.75 MiB 19.70 MiB 1.95 MiB
46e3d54+dirty 43.75 MiB 47.99 MiB 4.24 MiB
ebf60f9+dirty 43.75 MiB 48.07 MiB 4.32 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
9aa9f9b+dirty 464.02 ms 490.62 ms 26.60 ms
0816bdc+dirty 420.64 ms 447.37 ms 26.73 ms
326e1a7+dirty 426.45 ms 457.84 ms 31.39 ms
89237d0+dirty 405.30 ms 422.77 ms 17.46 ms

App size

Revision Plain With Sentry Diff
9aa9f9b+dirty 43.75 MiB 48.07 MiB 4.32 MiB
0816bdc+dirty 43.75 MiB 48.07 MiB 4.32 MiB
326e1a7+dirty 43.75 MiB 48.07 MiB 4.32 MiB
89237d0+dirty 43.75 MiB 48.08 MiB 4.33 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1206.39 ms 1203.90 ms -2.49 ms
Size 3.44 MiB 4.66 MiB 1.22 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
326e1a7+dirty 1188.46 ms 1201.64 ms 13.18 ms
89237d0+dirty 1220.00 ms 1217.90 ms -2.10 ms
0816bdc+dirty 1207.15 ms 1214.24 ms 7.10 ms
9aa9f9b+dirty 1217.00 ms 1212.65 ms -4.35 ms

App size

Revision Plain With Sentry Diff
326e1a7+dirty 3.41 MiB 4.74 MiB 1.33 MiB
89237d0+dirty 3.44 MiB 4.74 MiB 1.31 MiB
0816bdc+dirty 3.44 MiB 4.74 MiB 1.30 MiB
9aa9f9b+dirty 3.41 MiB 4.74 MiB 1.33 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1211.71 ms 1214.83 ms 3.12 ms
Size 3.44 MiB 4.66 MiB 1.22 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
326e1a7+dirty 1210.09 ms 1217.29 ms 7.20 ms
89237d0+dirty 1188.04 ms 1198.19 ms 10.15 ms
0816bdc+dirty 1223.46 ms 1221.28 ms -2.18 ms
9aa9f9b+dirty 1216.96 ms 1214.32 ms -2.64 ms

App size

Revision Plain With Sentry Diff
326e1a7+dirty 3.41 MiB 4.74 MiB 1.33 MiB
89237d0+dirty 3.44 MiB 4.74 MiB 1.31 MiB
0816bdc+dirty 3.44 MiB 4.74 MiB 1.30 MiB
9aa9f9b+dirty 3.41 MiB 4.74 MiB 1.33 MiB

@antonis antonis changed the title chore(deps): update Cocoa SDK to v9.0.0-alpha.0 chore(deps): update Cocoa SDK to v9.0.0-alpha Nov 13, 2025
@antonis
Copy link
Contributor Author

antonis commented Nov 13, 2025

fix(podspec): Cocoa V9 allow any alpha version

Thank you @philipphofmann 🦸

antonis and others added 2 commits November 13, 2025 12:00
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

---------

Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Denis Andrasec <[email protected]>
Co-authored-by: Noah Martin <[email protected]>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

* chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0

* Bump to 15.1 due to RN 0.81.0 requirements

---------

Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Itay Brenner <[email protected]>
Co-authored-by: Denis Andrasec <[email protected]>
Co-authored-by: Noah Martin <[email protected]>
@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Nov 13, 2025
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 13, 2025
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Dec 11, 2025
@antonis
Copy link
Contributor Author

antonis commented Dec 11, 2025

The CI is 🟢 again with 9.1.0 and the current issues are solved. The sample app also behaved as expected in my manual tests 🎉

@antonis antonis changed the base branch from main to v8 December 23, 2025 10:23
@antonis
Copy link
Contributor Author

antonis commented Dec 23, 2025

Changing the target branch to v8.

@antonis antonis marked this pull request as ready for review December 23, 2025 10:24
@antonis antonis mentioned this pull request Dec 23, 2025
Copy link
Contributor Author

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the Cocoa version to 9.1.0 that has been tested with 1d90b60

@antonis antonis merged commit f73c0ff into v8 Dec 23, 2025
99 of 104 checks passed
@antonis antonis deleted the cocoa-v9 branch December 23, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants