Skip to content

test_poll_blocking: Wait for worker threads to start before sleeping. #26405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −0
Open

test_poll_blocking: Wait for worker threads to start before sleeping. #26405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/core/test_poll_blocking.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,19 @@ void test_unblock_poll() {
close(pipe_shared[0]); close(pipe_shared[1]);
}

int threads_running = 0;
pthread_mutex_t running_lock = PTHREAD_MUTEX_INITIALIZER;
pthread_cond_t running_cv = PTHREAD_COND_INITIALIZER;

void *do_poll_in_thread(void * arg) {
struct timeval begin, end;

gettimeofday(&begin, NULL);
struct pollfd fds = {pipe_shared[0], POLLIN, 0};
pthread_mutex_lock(&running_lock);
threads_running++;
pthread_cond_signal(&running_cv);
pthread_mutex_unlock(&running_lock);
assert(poll(&fds, 1, 4000) == 1);
gettimeofday(&end, NULL);
assert(fds.revents & POLLIN);
Expand All @@ -130,6 +138,11 @@ void test_poll_in_threads() {

assert(pthread_create(&tid1, NULL, do_poll_in_thread, NULL) == 0);
assert(pthread_create(&tid2, NULL, do_poll_in_thread, NULL) == 0);
pthread_mutex_lock(&running_lock);
while (threads_running != 2) {
pthread_cond_wait(&running_cv, &running_lock);
}
pthread_mutex_unlock(&running_lock);

sleep_ms(2 * TIMEOUT_MS);
write(pipe_shared[1], t, strlen(t));
Expand Down
13 changes: 13 additions & 0 deletions test/core/test_select_blocking.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ void test_unblock_select() {
close(pipe_shared[0]); close(pipe_shared[1]);
}

int threads_running = 0;
pthread_mutex_t running_lock = PTHREAD_MUTEX_INITIALIZER;
pthread_cond_t running_cv = PTHREAD_COND_INITIALIZER;

void *do_select_in_thread(void * arg) {
struct timeval begin, end;
fd_set readfds;
Expand All @@ -120,6 +124,10 @@ void *do_select_in_thread(void * arg) {
int maxfd = pipe_shared[0];

gettimeofday(&begin, NULL);
pthread_mutex_lock(&running_lock);
threads_running++;
pthread_cond_signal(&running_cv);
pthread_mutex_unlock(&running_lock);
assert(select(maxfd + 1, &readfds, NULL, NULL, &tv) == 1);
gettimeofday(&end, NULL);
assert(FD_ISSET(pipe_shared[0], &readfds));
Expand All @@ -141,6 +149,11 @@ void test_select_in_threads() {

assert(pthread_create(&tid1, NULL, do_select_in_thread, NULL) == 0);
assert(pthread_create(&tid2, NULL, do_select_in_thread, NULL) == 0);
pthread_mutex_lock(&running_lock);
while (threads_running != 2) {
pthread_cond_wait(&running_cv, &running_lock);
}
pthread_mutex_unlock(&running_lock);

sleep_ms(2 * TIMEOUT_MS);
write(pipe_shared[1], t, strlen(t));
Expand Down