test_poll_blocking: Wait for worker threads to start before sleeping.#26405
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
test_poll_blocking: Wait for worker threads to start before sleeping.#26405sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
This means that even if the threads take a while to start they should still block for at least TIMEOUT_MS in poll/select.
Collaborator
|
You don't need to do this, but did you try this out with the changes in 9200517 ? |
Collaborator
Author
I think both changes are valid / needed. Not sure we need to test them combination. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that even if the threads take a while to start they should still block for at least TIMEOUT_MS in poll/select.