Skip to content

Comments

feat: add position prop to modal#4243

Open
amanabiy wants to merge 4 commits intomainfrom
dev-v3-amanabiy-modal-top-position
Open

feat: add position prop to modal#4243
amanabiy wants to merge 4 commits intomainfrom
dev-v3-amanabiy-modal-top-position

Conversation

@amanabiy
Copy link
Member

@amanabiy amanabiy commented Feb 11, 2026

Description

This PR adds a prop position to the modal to allow builders choose position of center or top. This is a follow up to this pull request which adds x-large and xx-large.

Related links, issue #, if available: gfq0AFhyrah9

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@amanabiy amanabiy changed the base branch from main to dev-v3-amanabiy-modal-new-sizes February 11, 2026 17:05
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-new-sizes branch from 6613b8b to aeafec3 Compare February 16, 2026 22:11
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-top-position branch from e3c0bbc to 7880511 Compare February 16, 2026 22:21
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-new-sizes branch from 874c6ae to 15c8acd Compare February 20, 2026 09:14
@amanabiy amanabiy changed the base branch from dev-v3-amanabiy-modal-new-sizes to main February 20, 2026 14:53
@amanabiy amanabiy marked this pull request as ready for review February 20, 2026 15:50
@amanabiy amanabiy requested a review from a team as a code owner February 20, 2026 15:50
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-top-position branch from 1d172fa to 7472532 Compare February 20, 2026 16:00
@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.42%. Comparing base (12d64a9) to head (c29e674).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4243   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         892      892           
  Lines       26116    26117    +1     
  Branches     9437     9438    +1     
=======================================
+ Hits        25444    25445    +1     
  Misses        666      666           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-top-position branch from c80cbe0 to 9cbd70d Compare February 23, 2026 06:35
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-top-position branch from 9cbd70d to cea0786 Compare February 23, 2026 08:44
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-top-position branch from d651c15 to 5197c64 Compare February 23, 2026 09:33
@amanabiy amanabiy changed the base branch from main to dev-v3-amanabiy-modal-new-sizes February 23, 2026 10:03
@amanabiy amanabiy changed the base branch from dev-v3-amanabiy-modal-new-sizes to main February 23, 2026 10:05
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-top-position branch from 8e3acc4 to ae2bea1 Compare February 23, 2026 10:07
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-top-position branch from ae2bea1 to 7546c8c Compare February 24, 2026 06:56
*
* - `top` - Modal anchors at fixed distance and grows downward
* as content expands. Use when content changes dynamically to prevent disruptive
* vertical repositioning that causes users to lose focus.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "focus" is not quite the right word as it might suggest keyboard focus

Suggested change
* vertical repositioning that causes users to lose focus.
* vertical repositioning that can cause users to lose context.

@@ -0,0 +1,24 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will both of these pages be added to visual regression tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they will be used in visual regression test.

@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-top-position branch from 7546c8c to 5bec116 Compare February 24, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants