Open
Conversation
6613b8b to
aeafec3
Compare
e3c0bbc to
7880511
Compare
874c6ae to
15c8acd
Compare
1d172fa to
7472532
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4243 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 892 892
Lines 26116 26117 +1
Branches 9437 9438 +1
=======================================
+ Hits 25444 25445 +1
Misses 666 666
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c80cbe0 to
9cbd70d
Compare
9cbd70d to
cea0786
Compare
d651c15 to
5197c64
Compare
8e3acc4 to
ae2bea1
Compare
ae2bea1 to
7546c8c
Compare
src/modal/interfaces.ts
Outdated
| * | ||
| * - `top` - Modal anchors at fixed distance and grows downward | ||
| * as content expands. Use when content changes dynamically to prevent disruptive | ||
| * vertical repositioning that causes users to lose focus. |
Member
There was a problem hiding this comment.
I think "focus" is not quite the right word as it might suggest keyboard focus
Suggested change
| * vertical repositioning that causes users to lose focus. | |
| * vertical repositioning that can cause users to lose context. |
| @@ -0,0 +1,24 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Member
There was a problem hiding this comment.
will both of these pages be added to visual regression tests?
Member
Author
There was a problem hiding this comment.
Yes, they will be used in visual regression test.
7546c8c to
5bec116
Compare
90c379b to
c29e674
Compare
gethinwebster
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a prop
positionto the modal to allow builders choose position of center or top. This is a follow up to this pull request which adds x-large and xx-large.Related links, issue #, if available: gfq0AFhyrah9
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.