Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4252 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 891 891
Lines 26098 26124 +26
Branches 9435 9455 +20
=======================================
+ Hits 25426 25452 +26
Misses 629 629
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
694e38d to
de4840d
Compare
2729d07 to
14fe57e
Compare
86bd2e1 to
e48dd57
Compare
e48dd57 to
7d6cc10
Compare
edd7556 to
e2d17f6
Compare
0e46e92 to
fec3d10
Compare
fec3d10 to
29ed6ca
Compare
9852f0e to
a34f8ce
Compare
a34f8ce to
4a740e3
Compare
jperals
reviewed
Feb 23, 2026
src/modal/interfaces.ts
Outdated
| /** | ||
| * Specifies the height of the modal. When provided, the modal content becomes scrollable if it exceeds the specified height. | ||
| * If the specified height exceeds available viewport space, the modal will use the maximum available space. | ||
| * The minimum height is constrained to ensure the content area is at least 60px for accessibility. |
Member
There was a problem hiding this comment.
"constrained" suggests that a maximum is applied to a given value, but here it is a minimum. Can we find a different phrasing? Is this the vertical equivalent of the minimum 320px width mentioned in the width prop above? If so, could we harmonize both descriptions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the Modal component with custom dimension support by adding width and height props, building on the position prop introduced in the previous PR.
Note: The base branch is
dev-v3-amanabiy-modal-top-positionto isolate changes from the position prop PR for easier review.New Features:
The base is made to
dev-v3-amanabiy-modal-top-positionso that you can review the main changes only related to this PR, and not the previous prs which adds position prop and different sizes.Behavior:
sizeRelated links, issue #, if available: gfq0AFhyrah9
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.