feat: add x-large and xx-large sizes to modal#4240
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4240 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 892 892
Lines 26116 26116
Branches 9437 9438 +1
=======================================
Hits 25444 25444
+ Misses 666 629 -37
- Partials 6 43 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6613b8b to
aeafec3
Compare
874c6ae to
15c8acd
Compare
3563f7d to
24d93c5
Compare
pan-kot
reviewed
Feb 23, 2026
pages/modal/sizes.page.tsx
Outdated
| const sizes = ['small', 'medium', 'large', 'x-large', 'xx-large', 'max'] as const; | ||
|
|
||
| return ( | ||
| <> |
Member
There was a problem hiding this comment.
nit: There is helper called SimplePage to reduce boilerplate in pages.
37ed361 to
bd1e120
Compare
3846b2a to
99fdbe7
Compare
pan-kot
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new size options to Modal component:
x-large(1024px) andxx-large(1280px).Related links, issue #, if available: gfq0AFhyrah9
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.