Skip to content

Comments

feat: add x-large and xx-large sizes to modal#4240

Open
amanabiy wants to merge 2 commits intomainfrom
dev-v3-amanabiy-modal-new-sizes
Open

feat: add x-large and xx-large sizes to modal#4240
amanabiy wants to merge 2 commits intomainfrom
dev-v3-amanabiy-modal-new-sizes

Conversation

@amanabiy
Copy link
Member

@amanabiy amanabiy commented Feb 11, 2026

Description

This PR adds two new size options to Modal component: x-large (1024px) and xx-large (1280px).

Related links, issue #, if available: gfq0AFhyrah9

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.42%. Comparing base (12d64a9) to head (99fdbe7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4240   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         892      892           
  Lines       26116    26116           
  Branches     9437     9438    +1     
=======================================
  Hits        25444    25444           
+ Misses        666      629   -37     
- Partials        6       43   +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-new-sizes branch from 6613b8b to aeafec3 Compare February 16, 2026 22:11
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-new-sizes branch from 874c6ae to 15c8acd Compare February 20, 2026 09:14
@amanabiy amanabiy marked this pull request as ready for review February 20, 2026 15:50
@amanabiy amanabiy requested a review from a team as a code owner February 20, 2026 15:50
@amanabiy amanabiy requested a review from SpyZzey February 20, 2026 15:50
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-modal-new-sizes branch from 3563f7d to 24d93c5 Compare February 20, 2026 15:58
const sizes = ['small', 'medium', 'large', 'x-large', 'xx-large', 'max'] as const;

return (
<>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: There is helper called SimplePage to reduce boilerplate in pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants