Open
Conversation
Previously, ArgparsePatternAction and ArgparsePatternFileAction appended recursion roots directly to args.paths. This mixed CLI positional paths with paths derived from patterns (e.g., using the `R` root path command in a pattern file), complicating downstream argument parsing and future jsonargparse integration. This commit introduces `args.pattern_roots` as a dedicated list for these accumulated root paths: - All argparse definition sites now initialize `pattern_roots=[]` alongside `paths=[]` - ArgparsePatternAction and ArgparsePatternFileAction write directly to `args.pattern_roots` - The build_matcher utility accepts both `include_paths` and `pattern_roots` and concatenates them internally - `create_cmd` iterations explicitly concatenate both lists before processing This ensures `args.paths` strictly reflects exactly what the user provided positionally, paving the way for a clean jsonargparse implementation without regressions in pattern behavior.
ThomasWaldmann
force-pushed
the
jsonargparse2
branch
2 times, most recently
from
89f6898 to
5aa0956
Compare
Closed
Guess it was triggered due to naming the variable "token", maybe "sort_key" is less problematic.
ThomasWaldmann
force-pushed
the
jsonargparse2
branch
from
5aa0956 to
7db38a1
Compare
ThomasWaldmann
commented
Feb 25, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9413 +/- ##
==========================================
+ Coverage 76.47% 76.51% +0.03%
==========================================
Files 85 86 +1
Lines 14803 14913 +110
Branches 2213 2250 +37
==========================================
+ Hits 11321 11411 +90
- Misses 2803 2813 +10
- Partials 679 689 +10 ☔ View full report in Codecov by Sentry. |
other validators / specs are also there and it is easier to maintain as Python code. the compress module is Cython code.
ThomasWaldmann
force-pushed
the
jsonargparse2
branch
2 times, most recently
from
14adfd2 to
c6452f7
Compare
Member
Author
|
@mauvilsa can you have a look, please? maybe look at the individual commits. is that had to import some internal stuff to implement guess this can soon be merged - it does not use most features of jsonargparse, but that should be in future PRs. |
Open
ThomasWaldmann
force-pushed
the
jsonargparse2
branch
from
c6452f7 to
5b9b450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adopt jsonargparse, fixes #6551.
Checklist
master(or maintenance branch if only applicable there)toxor the relevant test subset)