Use jsonargparse

[ThomasWaldmann]

WIP

[codecov]

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
1623	2	1621	346

View the top 2 failed test(s) by shortest run time

src.borg.testsuite.archiver.create_cmd_test::test_create_pattern_root[archiver]

Stack Traces | 0.338s run time

archivers = 'archiver'
request = <FixtureRequest for <Function test_create_pattern_root[archiver]>>

    def test_create_pattern_root(archivers, request):
        """test create with only a root pattern"""
        archiver = request.getfixturevalue(archivers)
        cmd(archiver, "repo-create", RK_ENCRYPTION)
        create_regular_file(archiver.input_path, "file1", size=1024 * 80)
        create_regular_file(archiver.input_path, "file2", size=1024 * 80)
>       output = cmd(archiver, "create", "test", "-v", "--list", "--pattern=R input")
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

.../testsuite/archiver/create_cmd_test.py:434: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

archiver = <borg.conftest.ArchiverSetup object at 0x7fca7cb86170>
args = ('create', 'test', '-v', '--list', '--pattern=R input'), kw = {}
exit_code = 0, fork = False, binary_output = False, ret = 2
output = 'usage: -c [--cockpit] [--critical] [--error] [--warning] [--info] [--debug]\n          [--debug-topic TOPIC] [-p] [--...nchmark,debug,key} ...\ntip: For details of accepted options run: -c --help\nerror: Need at least one PATH argument.\n'
@py_assert1 = False, @py_format3 = '2 == 0', @py_format5 = 'assert 2 == 0'

    def cmd(archiver, *args, **kw):
        exit_code = kw.pop("exit_code", 0)
        fork = kw.pop("fork", None)
        binary_output = kw.get("binary_output", False)
        if fork is None:
            fork = archiver.FORK_DEFAULT
        ret, output = exec_cmd(
            f"--repo={archiver.repository_location}", *args, archiver=archiver.archiver, fork=fork, exe=archiver.EXE, **kw
        )
        if ret != exit_code:
            print(output)
>       assert ret == exit_code
E       assert 2 == 0

.../testsuite/archiver/__init__.py:152: AssertionError

src.borg.testsuite.archiver.create_cmd_test::test_create_pattern_root[remote_archiver]

Stack Traces | 1.45s run time

archivers = 'remote_archiver'
request = <FixtureRequest for <Function test_create_pattern_root[remote_archiver]>>

    def test_create_pattern_root(archivers, request):
        """test create with only a root pattern"""
        archiver = request.getfixturevalue(archivers)
        cmd(archiver, "repo-create", RK_ENCRYPTION)
        create_regular_file(archiver.input_path, "file1", size=1024 * 80)
        create_regular_file(archiver.input_path, "file2", size=1024 * 80)
>       output = cmd(archiver, "create", "test", "-v", "--list", "--pattern=R input")
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

.../testsuite/archiver/create_cmd_test.py:434: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

archiver = <borg.conftest.ArchiverSetup object at 0x7fca781ec870>
args = ('create', 'test', '-v', '--list', '--pattern=R input'), kw = {}
exit_code = 0, fork = False, binary_output = False, ret = 2
output = 'usage: -c [--cockpit] [--critical] [--error] [--warning] [--info] [--debug]\n          [--debug-topic TOPIC] [-p] [--...nchmark,debug,key} ...\ntip: For details of accepted options run: -c --help\nerror: Need at least one PATH argument.\n'
@py_assert1 = False, @py_format3 = '2 == 0', @py_format5 = 'assert 2 == 0'

    def cmd(archiver, *args, **kw):
        exit_code = kw.pop("exit_code", 0)
        fork = kw.pop("fork", None)
        binary_output = kw.get("binary_output", False)
        if fork is None:
            fork = archiver.FORK_DEFAULT
        ret, output = exec_cmd(
            f"--repo={archiver.repository_location}", *args, archiver=archiver.archiver, fork=fork, exe=archiver.EXE, **kw
        )
        if ret != exit_code:
            print(output)
>       assert ret == exit_code
E       assert 2 == 0

.../testsuite/archiver/__init__.py:152: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[mauvilsa]

FIY, with pull request omni-us/jsonargparse#845 now it is possible to add arguments with type and action. Not yet in a release, but the dependency could be set to install directly from the github main branch. I haven't yet looked at the pull request in detail.

[ThomasWaldmann]

@mauvilsa Ah, that's great, thanks for the info.

That limitation was one of the major pain points in switching to jsonargparse.

[ThomasWaldmann]

superceded by #9413

[ThomasWaldmann]

@mauvilsa that type+action change was very helpful for borg, thanks.

doing #9413 was quite a bit easier than this first try.