Skip to content

MINIFICPP-2757 Build windows artifacts in create-release-artifacts CI #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinzink wants to merge 4 commits into
base: main
Choose a base branch
from
Open

MINIFICPP-2757 Build windows artifacts in create-release-artifacts CI #2145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02875f6
MINIFICPP-2757 Build windows artifacts in create-release-artifacts.ym…
martinzink Mar 11, 2026
fbaf35a
fix windows build
martinzink Mar 25, 2026
09a8cef
skip tests
martinzink Mar 26, 2026
4918d5b
replace & with &&
Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 63 additions & 1 deletion .github/workflows/create-release-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: "Create Release Artifacts"

on: [workflow_dispatch]
env:
CMAKE_FLAGS: -DCMAKE_BUILD_TYPE=Release -DCI_BUILD=OFF -DENABLE_ALL=ON -DMINIFI_FAIL_ON_WARNINGS=OFF -DDOCKER_BUILD_ONLY=ON
CMAKE_FLAGS: -DCMAKE_BUILD_TYPE=Release -DCI_BUILD=OFF -DENABLE_ALL=ON -DMINIFI_FAIL_ON_WARNINGS=OFF -DDOCKER_BUILD_ONLY=ON -DSKIP_TESTS=ON

jobs:
build-linux-artifacts:
Expand Down Expand Up @@ -40,3 +40,65 @@ jobs:
with:
name: ${{ matrix.platform.rpm-artifact }}
path: build/nifi-minifi-cpp-*.rpm
windows_VS2022:
name: "Windows Server 2025 x86_64"
runs-on: windows-2025
timeout-minutes: 240
steps:
- name: Support longpaths
run: git config --system core.longpaths true
- name: Checkout project
uses: actions/checkout@v4
- name: Set up Python
run: choco -y install python & refreshenv
shell: cmd
- name: Install sqliteodbc driver
run: |
Invoke-WebRequest -Uri "http://www.ch-werner.de/sqliteodbc/sqliteodbc_w64.exe" -OutFile "sqliteodbc_w64.exe"
if ((Get-FileHash 'sqliteodbc_w64.exe').Hash -ne "a4804e4f54f42c721df1323c5fcac101a8c7a577e7f20979227324ceab572d51") {Write "Hash mismatch"; Exit 1}
Start-Process -FilePath ".\sqliteodbc_w64.exe" -ArgumentList "/S" -Wait
shell: powershell
- name: build
run: |
python -m venv venv && venv\Scripts\activate && pip install -r requirements.txt && python main.py --noninteractive --skip-compiler-install --minifi-options="-DCMAKE_BUILD_TYPE=Release -DCI_BUILD=OFF -DENABLE_ALL=ON -DMINIFI_FAIL_ON_WARNINGS=OFF -DSKIP_TESTS=ON"
shell: cmd
working-directory: bootstrap
- name: Upload artifact
uses: actions/upload-artifact@v4
with:
name: minifi-x86_64-msi
path: build/nifi-minifi-cpp.msi
extension-sdk:
name: "Extension SDK"
runs-on: 'ubuntu-24.04-arm'
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.10'

- name: Build Python Wheel
run: |
python -m pip install --upgrade pip
pip install build
cd behave_framework
python -m build

- name: Bundle SDK Artifacts into ZIP
run: |
mkdir minifi-native-sdk

cp behave_framework/dist/*.whl minifi-native-sdk/
cp minifi-api/minifi-c-api.def minifi-native-sdk/
cp minifi-api/include/minifi-c/minifi-c.h minifi-native-sdk/

zip -r minifi-native-sdk.zip minifi-native-sdk/

- name: Upload artifact
uses: actions/upload-artifact@v4
with:
name: minifi-native-sdk
path: minifi-native-sdk.zip
5 changes: 4 additions & 1 deletion behave_framework/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,7 @@ dependencies = [

[tool.setuptools]
package-dir = {"" = "src"}
packages = ["minifi_test_framework"]

[tool.setuptools.packages.find]
where = ["src"]
include = ["minifi_test_framework*"]
Empty file added behave_framework/src/minifi_test_framework/core/__init__.py
View file
Open in desktop
Empty file.
Empty file added behave_framework/src/minifi_test_framework/steps/__init__.py
View file
Open in desktop
Empty file.
2 changes: 1 addition & 1 deletion extensions/sftp/tests/tools/SFTPTestServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,10 @@ bool SFTPTestServer::stop() {
logger_->log_debug("Deleting port file {}", port_file_path_);
::unlink(port_file_path_.c_str());
}
#endif
server_pid_ = -1;
Copy link
Copy Markdown
Member Author

@martinzink martinzink Mar 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the bugfix part

it failed to compiled because server_pid_ is not declared on windows, since we already throw I've moved the endif a bit

Copy link
Copy Markdown
Member Author

@martinzink martinzink Mar 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still has compile issues. I've checked and we dont enable SFTP on windows CI job, and locally it skips the tests if java or maven is missing, thats why it could fly under our radar.

Since this would require a bigger effort, this is not the PR to fix these I've created a new jira for this effort, and disabled tests for this job (we dont run tests anyway in these jobs so it makes sense to skip them here)

https://issues.apache.org/jira/browse/MINIFICPP-2759

started_ = false;
port_file_path_ = "";
#endif
return true;
}

Expand Down
Loading