MINIFICPP-2757 Build windows artifacts in create-release-artifacts CI#2145
MINIFICPP-2757 Build windows artifacts in create-release-artifacts CI#2145martinzink wants to merge 4 commits intoapache:mainfrom
Conversation
martinzink
added
low-impact
| ::unlink(port_file_path_.c_str()); | ||
| } | ||
| #endif | ||
| server_pid_ = -1; |
There was a problem hiding this comment.
this is the bugfix part
it failed to compiled because server_pid_ is not declared on windows, since we already throw I've moved the endif a bit
There was a problem hiding this comment.
It still has compile issues. I've checked and we dont enable SFTP on windows CI job, and locally it skips the tests if java or maven is missing, thats why it could fly under our radar.
Since this would require a bigger effort, this is not the PR to fix these I've created a new jira for this effort, and disabled tests for this job (we dont run tests anyway in these jobs so it makes sense to skip them here)
There was a problem hiding this comment.
Pull request overview
Adds Windows MSI and extension SDK artifacts to the create-release-artifacts CI workflow, and adjusts Python packaging + a small test utility fix to support release artifact generation.
Changes:
- Add a Windows Server runner job to build and upload the MSI artifact in
create-release-artifacts. - Add an “Extension SDK” job that builds a Python wheel and bundles SDK files into a ZIP artifact.
- Update setuptools packaging configuration for
behave_frameworkand adjust a preprocessor guard placement in the SFTP test server.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| extensions/sftp/tests/tools/SFTPTestServer.cpp | Moves a preprocessor #endif, changing which statements are conditionally compiled. |
| behave_framework/pyproject.toml | Switches from explicit packages = [...] to setuptools automatic package discovery. |
| .github/workflows/create-release-artifacts.yml | Adds Windows MSI build/upload job and new Extension SDK artifact build/bundle job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.