-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Admin Reskin: Frame #10936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabiankaegy
wants to merge
8
commits into
WordPress:trunk
Choose a base branch
from
fabiankaegy:feature/frame
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+91
−32
Open
Admin Reskin: Frame #10936
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
27b73f6
Admin: Add framed layout with scrollable content area and rounded cor…
fabiankaegy c4a59b8
Admin: Fix block editor frame positioning and dashboard drag zone spa…
fabiankaegy 41d9f37
Admin: Keep editor skeleton fixed positioning for frame layout.
fabiankaegy 921f158
Admin: Use flex column on wpbody-content for footer and screen meta l…
fabiankaegy 5668b82
fix mobile behavior
fabiankaegy c9dee1a
fix use 8px instead of 16
fabiankaegy 87f0b12
Remove background on editor tools (classic editor)
joedolson 71bf213
Merge branch 'trunk' into pr/10936
joedolson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,72 @@ | ||
| /* 2 column liquid layout */ | ||
| #wpwrap { | ||
| height: auto; | ||
| min-height: 100%; | ||
| height: calc(100vh - var(--wp-admin--admin-bar--height, 32px)); | ||
| width: 100%; | ||
| position: relative; | ||
| -webkit-font-smoothing: subpixel-antialiased; | ||
| background: #1e1e1e; | ||
| overflow: hidden; | ||
| } | ||
|
|
||
| #wpcontent { | ||
| height: 100%; | ||
| padding-left: 20px; | ||
| padding: 0 8px 8px 0; | ||
| display: flex; | ||
| flex-direction: column; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| #wpcontent, | ||
| #wpfooter { | ||
| #wpcontent { | ||
| margin-left: 160px; | ||
| } | ||
|
|
||
| .folded #wpcontent, | ||
| .folded #wpfooter { | ||
| .folded #wpcontent { | ||
| margin-left: 36px; | ||
| } | ||
|
|
||
| #wpbody { | ||
| flex: 1; | ||
| min-height: 0; | ||
| } | ||
|
|
||
| #wpbody-content { | ||
| padding-bottom: 65px; | ||
| float: left; | ||
| width: 100%; | ||
| overflow: visible; | ||
| position: relative; | ||
| height: 100%; | ||
| box-sizing: border-box; | ||
| display: flex; | ||
| flex-direction: column; | ||
| overflow-y: auto; | ||
| overscroll-behavior: none; | ||
| background: #fff; | ||
| border-radius: 8px; | ||
| } | ||
|
|
||
| /* Block editor frame overrides */ | ||
| body.js.block-editor-page #wpbody-content { | ||
| padding-bottom: 0; | ||
| overflow: hidden; | ||
| } | ||
|
|
||
| body.js.block-editor-page:not(.is-fullscreen-mode) .interface-interface-skeleton { | ||
| right: 8px; | ||
| bottom: 8px; | ||
| border-radius: 8px; | ||
| overflow: hidden; | ||
| } | ||
|
|
||
| /* Fullscreen mode: remove frame */ | ||
| body.is-fullscreen-mode #wpwrap { | ||
| height: 100vh; | ||
| background: #fff; | ||
| } | ||
|
|
||
| body.is-fullscreen-mode #wpcontent { | ||
| padding: 0; | ||
| margin-left: 0; | ||
| } | ||
|
|
||
| body.is-fullscreen-mode #wpbody-content { | ||
| border-radius: 0; | ||
| } | ||
|
|
||
| /* inner 2 column liquid layout */ | ||
|
|
@@ -222,7 +262,7 @@ body { | |
| } | ||
|
|
||
| body { | ||
| background: #f0f0f1; | ||
| background: #fff; | ||
| color: #3c434a; | ||
| font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif; | ||
| font-size: 13px; | ||
|
|
@@ -584,7 +624,9 @@ code { | |
| } | ||
|
|
||
| .wrap { | ||
| margin: 10px 20px 0 2px; | ||
| margin: 0; | ||
| padding: 10px 20px 0 20px; | ||
| margin-top: -32px; | ||
| } | ||
|
|
||
| .wrap > h2:first-child, /* Back-compat for pre-4.4 */ | ||
|
|
@@ -1846,14 +1888,14 @@ p.auto-update-status { | |
| } | ||
|
|
||
| #screen-meta-links { | ||
| float: right; | ||
| align-self: flex-end; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change causes the 'Enable Accessibility Mode' link for turning on the widget accessibility mode to fall behind the Help toggle. When they were both floated, they respected each other's boundaries; but with this, they don't. |
||
| margin: 0 20px 0 0; | ||
| } | ||
|
|
||
| /* screen options and help tabs revert */ | ||
| #screen-meta { | ||
| display: none; | ||
| margin: 0 20px -1px 0; | ||
| margin: 0 20px -1px 20px; | ||
| position: relative; | ||
| background-color: #fff; | ||
| border: 1px solid #c3c4c7; | ||
|
|
@@ -2353,12 +2395,10 @@ html.wp-toolbar { | |
| ------------------------------------------------------------------------------*/ | ||
|
|
||
| #wpfooter { | ||
| position: absolute; | ||
| bottom: 0; | ||
| left: 0; | ||
| right: 0; | ||
| padding: 10px 20px; | ||
| color: #50575e; | ||
| margin-top: auto; | ||
| padding-top: 24px; | ||
| } | ||
|
|
||
| #wpfooter p { | ||
|
|
@@ -2417,8 +2457,8 @@ h3 .nav-tab, /* Back-compat for pre-4.4 */ | |
| .nav-tab-active:hover, | ||
| .nav-tab-active:focus, | ||
| .nav-tab-active:focus:active { | ||
| border-bottom: 1px solid #f0f0f1; | ||
| background: #f0f0f1; | ||
| border-bottom: 1px solid #fff; | ||
| background: #fff; | ||
| color: #000; | ||
| } | ||
|
|
||
|
|
@@ -3991,20 +4031,38 @@ img { | |
| -webkit-tap-highlight-color: rgba(0, 0, 0, 0) !important; | ||
| } | ||
|
|
||
| #wpwrap { | ||
| height: auto; | ||
| overflow: visible; | ||
| background: none; | ||
| } | ||
|
|
||
| #wpcontent { | ||
| position: relative; | ||
| margin-left: 0; | ||
| padding-left: 10px; | ||
| padding: 0; | ||
| height: auto; | ||
| display: block; | ||
| } | ||
|
|
||
| #wpbody { | ||
| min-height: 0; | ||
| } | ||
|
|
||
| #wpbody-content { | ||
| padding-bottom: 100px; | ||
| border-radius: 0; | ||
| height: auto; | ||
| overflow: visible; | ||
| display: block; | ||
| background: none; | ||
| overscroll-behavior: auto; | ||
| } | ||
|
|
||
| .wrap { | ||
| clear: both; | ||
| margin-right: 12px; | ||
| margin-left: 0; | ||
| margin: 0; | ||
| padding: 10px 12px 0; | ||
| } | ||
|
|
||
| /* categories */ | ||
|
|
@@ -4272,9 +4330,11 @@ img { | |
| #screen-meta, | ||
| #screen-meta-links { | ||
| margin-right: 10px; | ||
| margin-left: 10px; | ||
| } | ||
|
|
||
| #screen-meta-links { | ||
| float: right; | ||
| margin-bottom: 20px; /* Add margins beneath links for better spacing between boxes and elements */ | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.