Conversation
…ners. Restructures the admin layout to use a flex-based framed design with a dark background, rounded white content area, scrollable wpbody-content, and consistent spacing for screen meta panels and responsive breakpoints.
…cing. Override the editor skeleton's fixed positioning to absolute so it fits within the framed layout, with a 16px bottom offset for the frame gap. Remove padding-bottom from wpbody-content and add margin to dashboard drag zone placeholders.
Use the skeleton's native fixed positioning instead of absolute, adjusting right and bottom offsets for the frame gap. Add border-radius and overflow hidden to clip content to rounded corners. Scoped to non-fullscreen mode.
…ayout. Make wpbody-content a flex column so the footer sticks to the bottom via margin-top: auto. Use align-self: flex-end on screen-meta-links instead of float so the toggle buttons stay in flow and get pushed down when the help/screen options panel expands.
fabiankaegy
requested review from
aaronjorbin,
audrasjb,
jasmussen,
joedolson and
peterwilsoncc
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| margin: 0; | ||
| padding: 10px 20px 0 20px; | ||
| margin-top: -32px; |
There was a problem hiding this comment.
| margin: 0; | |
| padding: 10px 20px 0 20px; | |
| margin-top: -32px; | |
| margin: -32px 0 0; | |
| padding: 10px 20px 0 20px; |
Background behind editor tabs & add media button.
|
|
||
| #screen-meta-links { | ||
| float: right; | ||
| align-self: flex-end; |
There was a problem hiding this comment.
This change causes the 'Enable Accessibility Mode' link for turning on the widget accessibility mode to fall behind the Help toggle. When they were both floated, they respected each other's boundaries; but with this, they don't.
3 participants
Trac ticket: https://core.trac.wordpress.org/ticket/64641
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.