Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Packages/com.unity.visualeffectgraph/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ The version number for this package has increased due to a version update of a r

This version is compatible with Unity 6000.6.0a7.

## Fixed
- Fixed case sensitivity for VFX Graph asset file extensions.

For the release notes, refer to the [Unity download archive](https://unity.com/releases/editor/archive).

## [17.4.0] - 2025-10-22
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System;
using System.Collections.Generic;
using System.Linq;

Expand Down Expand Up @@ -401,7 +402,7 @@ bool ProviderFilter(IVFXModelDescriptor descriptor)
if (descriptor.modelType == typeof(VisualEffectSubgraphOperator))
{
var path = (string)descriptor.variant.settings.Single(x => x.Key == "path").Value;
if (!path.StartsWith(VisualEffectAssetEditorUtility.templatePath) && path.EndsWith(VisualEffectSubgraphOperator.Extension))
if (!path.StartsWith(VisualEffectAssetEditorUtility.templatePath) && path.EndsWith(VisualEffectSubgraphOperator.Extension, StringComparison.OrdinalIgnoreCase))
{
var subGraph = AssetDatabase.LoadAssetAtPath<VisualEffectSubgraphOperator>(path);
if (subGraph != null && (!controller.viewController.model.isSubgraph || !subGraph.GetResource().GetOrCreateGraph().subgraphDependencies.Contains(controller.viewController.model.subgraph) && subGraph.GetResource() != controller.viewController.model))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ void OnPreprocessAsset()
{
if (!allowExternalization)
return;
bool isVFX = assetPath.EndsWith(VisualEffectResource.Extension);
bool isVFX = assetPath.EndsWith(VisualEffectResource.Extension, StringComparison.OrdinalIgnoreCase);
if (isVFX)
{
string vfxName = Path.GetFileNameWithoutExtension(assetPath);
Expand All @@ -49,7 +49,7 @@ void OnPreprocessAsset()

foreach (var shaderPath in Directory.GetFiles(shaderDirectory))
{
if (shaderPath.EndsWith(k_ShaderExt))
if (shaderPath.EndsWith(k_ShaderExt, StringComparison.OrdinalIgnoreCase))
{
System.IO.StreamReader file = new System.IO.StreamReader(shaderPath);

Expand Down Expand Up @@ -144,7 +144,7 @@ public static bool OnOpenVFX(EntityId entityId, int line)
else if (obj is Material || obj is Shader || obj is ComputeShader)
{
var path = AssetDatabase.GetAssetPath(entityId);
if (path.EndsWith(VisualEffectResource.Extension))
if (path.EndsWith(VisualEffectResource.Extension, StringComparison.OrdinalIgnoreCase))
{
var resource = VisualEffectResource.GetResourceAtPath(path);
if (resource != null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public void RaiseTemplateUsed(GraphViewTemplateDescriptor usedTemplate)
internal static bool TryGetTemplateStatic(string vfxPath, out GraphViewTemplateDescriptor graphViewTemplate)
{
// Can happen because the search engine sometimes finds prefabs
if (!vfxPath.EndsWith(VisualEffectResource.Extension))
if (!vfxPath.EndsWith(VisualEffectResource.Extension, StringComparison.OrdinalIgnoreCase))
{
graphViewTemplate = default;
return false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ private void OnPostprocessBuildInternal(IBuildReport report)
var assetsCount = 0;
foreach (var sourceAssetPath in report.packedAssetsInfoPath.Distinct())
{
if (sourceAssetPath.EndsWith(".vfx", StringComparison.OrdinalIgnoreCase))
if (sourceAssetPath.EndsWith(VisualEffectResource.Extension, StringComparison.OrdinalIgnoreCase))
{
assetsCount++;
}
Expand Down