[repro] findOne returns array instead of single object in angular-db (issue #1261)#1272
Open
claude[bot] wants to merge 3 commits intomainfrom
Open
[repro] findOne returns array instead of single object in angular-db (issue #1261)#1272claude[bot] wants to merge 3 commits intomainfrom
claude[bot] wants to merge 3 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This was referenced Feb 19, 2026
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 92.1 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.7 kB ℹ️ View Unchanged
|
Adds inject-live-query.test-d.ts with expectTypeOf assertions verifying that injectLiveQuery with findOne() types data as Signal<Person | undefined> and regular queries type data as Signal<Array<T>>. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
b53ee5c to
0689ccc
Compare
- Add NonSingleResult to createMockCollection return type since mock collections are never singleResult - Add non-null assertions for collection() signal access in tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
injectLiveQuerywithfindOne()returns a single object instead of an arraymainbecausedata()returns[{ id: '3', ... }](array) instead of{ id: '3', ... }(object)Linked issue: #1261
What the test asserts
Array.isArray(data())isfalse(currentlytrue)data()matches{ id: '3', name: 'John Smith' }as a plain objectHow to run
pnpm --filter @tanstack/angular-db test -- --runObserved failure
🤖 Generated with Claude Code