[fix] findOne returns array instead of single object in angular-db (issue #1261)#1273
Open
claude[bot] wants to merge 6 commits intomainfrom
Open
[fix] findOne returns array instead of single object in angular-db (issue #1261)#1273claude[bot] wants to merge 6 commits intomainfrom
claude[bot] wants to merge 6 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 60c11dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 92.1 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.7 kB ℹ️ View Unchanged
|
e3470e6 to
dc6786d
Compare
Adds inject-live-query.test-d.ts with expectTypeOf assertions verifying that injectLiveQuery with findOne() types data as Signal<Person | undefined> and regular queries type data as Signal<Array<T>>. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dc6786d to
de4d6dd
Compare
- Add NonSingleResult to createMockCollection return type since mock collections are never singleResult - Add non-null assertions for collection() signal access in tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… (issue #1261) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
de4d6dd to
31bb75c
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
injectLiveQueryin@tanstack/angular-dbto return a single object (orundefined) when used withfindOne(), instead of always returning an arraySignal<T | undefined>forfindOne()queriesFixes #1261
Repro PR: #1272
Root cause
The angular-db adapter was missing the
singleResulthandling that was already implemented in react-db and vue-db. Specifically:Runtime:
syncDataFromCollectionalways converted collection values to an array viaArray.from(currentCollection.values())and set it directly on thedatasignal. It never checkedcollection.config.singleResultto decide whether to return a single item or the full array.Types:
InjectLiveQueryResult.datawas always typed asSignal<Array<TResult>>, with no way to expressSignal<TResult | undefined>forfindOne()queries.Fix
computedsignal fordatathat checkscollection.config.singleResultand returns either the first element or the full array (matching the pattern in vue-db and react-db)InjectLiveQueryResultto useInferResultType<TContext>for thedatasignal type, which correctly resolves toT | undefinedforSingleResultcontexts andArray<T>otherwiseInjectLiveQueryResultWithCollectionandInjectLiveQueryResultWithSingleResultCollectioninterfaces for pre-created collection overloadsHow to test
pnpm --filter @tanstack/angular-db test -- --runAll 21 tests pass, including the new
findOnetest.🤖 Generated with Claude Code