Skip to content

remove pip.conf migration code in CI scripts, fix pr-builder configuration #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 5 commits into from
Feb 4, 2026
Merged

remove pip.conf migration code in CI scripts, fix pr-builder configuration #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd738dc
CI scripts: remove pip.conf migration code
jameslamb Feb 2, 2026
0d43cc6
empty commit to re-trigger CI
jameslamb Feb 3, 2026
4a9b06d
Merge branch 'main' of github.com:NVIDIA/cuopt into rapids-init-pip-u…
jameslamb Feb 4, 2026
3c86ee2
empty commit to re-trigger CI
jameslamb Feb 4, 2026
20c564e
fix pr-builder configuration
jameslamb Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ jobs:
- test-self-hosted-server
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@main
if: always()
with:
needs: ${{ toJSON(needs) }}
check-lean-ci:
runs-on: ubuntu-latest
outputs:
Expand Down
2 changes: 0 additions & 2 deletions ci/build_wheel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ package_dir=$2

source rapids-configure-sccache
source rapids-date-string
RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true"
export RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX
Copy link
Member Author

@jameslamb jameslamb Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just picking an arbitrary place on the diff to re-post this comment, so follow-ups can be grouped together in a thread.

hmmmm I'm not really sure why this isn't mergeable. pr-builder / run is getting skipped:

image

https://github.com/NVIDIA/cuopt/actions/runs/21615281140/job/62369023603?pr=821

I tried manually re-running it and it was skipped again.

Maybe the changes from #805 and/or this PR have left it in a weird state? I'll investigate. It shouldn't be the case that things like docs-build being skipped cause the entire pr-builder run to be skipped.

Copy link
Member Author

@jameslamb jameslamb Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, there's a GitHub outage affecting status checks: https://www.githubstatus.com/incidents/f314nlctbfs5

Copy link
Member Author

@jameslamb jameslamb Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub say they've pushed a fix but re-running the pr-builder job, it still showed as skipped. I've just fully re-run all CI on this PR... it's possible that other status checks from earlier jobs were lost during the incident or something.

If that still fails, I'll investigate whether there's something else going on here, maybe unrelated to that GitHub incident.

Copy link
Member Author

@jameslamb jameslamb Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jobs getting skipped should be no problem for pr-builder:

https://github.com/rapidsai/shared-workflows/blob/ce125aca3e92a02adb84a78f7361424bc08ee62c/.github/workflows/pr-builder.yaml#L20

I haven't seen this problem in any other repo using that. My theories right now are either that this PR was in a weird state because of the GitHub incident related to statuses today, or that some of this custom stuff done in this repo is confusing the check:

cuopt/.github/workflows/pr.yaml

Line 38 in ac400cd

check-lean-ci:

cuopt/.github/workflows/pr.yaml

Line 61 in ac400cd

prevent-merge-with-lean-ci:

cuopt/.github/workflows/pr.yaml

Line 76 in ac400cd

compute-matrix-filters:

Copy link
Member Author

@jameslamb jameslamb Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! I see the problem!

pr-builder is misconfigured here:

  • needs an if: always() to ensure it isn't skipped when other jobs are skipped
  • needs to actually pass the list of required jobs through to the workflow

Like this:

https://github.com/rapidsai/cudf/blob/b978750d0af8ddb20f4112fdbd6936e49297eafc/.github/workflows/pr.yaml#L47-L49

The fact that those were missing means this workflow has probably never worked in this repo and it's been doing a full run of CI on every commit 🙃

Just pushed 20c564e fixing that.

Copy link
Collaborator

@rgsl888prabhu rgsl888prabhu Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jameslamb, I always assumed it was designed by default

source rapids-init-pip

# Update the version to accomdate nightly and release changes for the wheel name
Expand Down
2 changes: 0 additions & 2 deletions ci/build_wheel_cuopt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

set -euo pipefail

RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true"
export RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX
source rapids-init-pip

# Install rockylinux repo
Expand Down
2 changes: 0 additions & 2 deletions ci/build_wheel_cuopt_mps_parser.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

set -euo pipefail

RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true"
export RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX
source rapids-init-pip

package_dir="python/cuopt/cuopt/linear_programming"
Expand Down
2 changes: 0 additions & 2 deletions ci/build_wheel_cuopt_server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@

set -euo pipefail

RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true"
export RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX
source rapids-init-pip

package_dir="python/cuopt_server"
Expand Down
2 changes: 0 additions & 2 deletions ci/build_wheel_cuopt_sh_client.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@

set -euo pipefail

RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true"
export RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX
source rapids-init-pip

package_dir="python/cuopt_self_hosted"
Expand Down
2 changes: 0 additions & 2 deletions ci/build_wheel_libcuopt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

set -euo pipefail

RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true"
export RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX
source rapids-init-pip

package_name="libcuopt"
Expand Down
2 changes: 0 additions & 2 deletions ci/test_self_hosted_service.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@

set -euo pipefail

RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true"
export RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX
source rapids-init-pip

# Download the cuopt built in the previous step
Expand Down
2 changes: 0 additions & 2 deletions ci/test_wheel_cuopt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ set -euo pipefail

# sets up a constraints file for 'pip' and puts its location in an exported variable PIP_EXPORT,
# so those constraints will affect all future 'pip install' calls
RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true"
export RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX
source rapids-init-pip

# Download the packages built in the previous step
Expand Down
2 changes: 0 additions & 2 deletions ci/test_wheel_cuopt_server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@

set -eou pipefail

RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true"
export RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX
source rapids-init-pip

# Download the packages built in the previous step
Expand Down
Loading