remove pip.conf migration code in CI scripts, fix pr-builder configuration#821
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughWalkthroughRemoved explicit initialization and export of the RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX environment variable from multiple CI build/test scripts; updated PR workflow step to run unconditionally and forward the full Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/merge |
| source rapids-configure-sccache | ||
| source rapids-date-string | ||
| RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true" | ||
| export RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX |
There was a problem hiding this comment.
Just picking an arbitrary place on the diff to re-post this comment, so follow-ups can be grouped together in a thread.
hmmmm I'm not really sure why this isn't mergeable. pr-builder / run is getting skipped:
https://github.com/NVIDIA/cuopt/actions/runs/21615281140/job/62369023603?pr=821
I tried manually re-running it and it was skipped again.
Maybe the changes from #805 and/or this PR have left it in a weird state? I'll investigate. It shouldn't be the case that things like docs-build being skipped cause the entire pr-builder run to be skipped.
There was a problem hiding this comment.
Ah, there's a GitHub outage affecting status checks: https://www.githubstatus.com/incidents/f314nlctbfs5
There was a problem hiding this comment.
GitHub say they've pushed a fix but re-running the pr-builder job, it still showed as skipped. I've just fully re-run all CI on this PR... it's possible that other status checks from earlier jobs were lost during the incident or something.
If that still fails, I'll investigate whether there's something else going on here, maybe unrelated to that GitHub incident.
There was a problem hiding this comment.
Jobs getting skipped should be no problem for pr-builder:
I haven't seen this problem in any other repo using that. My theories right now are either that this PR was in a weird state because of the GitHub incident related to statuses today, or that some of this custom stuff done in this repo is confusing the check:
cuopt/.github/workflows/pr.yaml
Line 38 in ac400cd
cuopt/.github/workflows/pr.yaml
Line 61 in ac400cd
cuopt/.github/workflows/pr.yaml
Line 76 in ac400cd
There was a problem hiding this comment.
Aha! I see the problem!
pr-builder is misconfigured here:
- needs an
if: always()to ensure it isn't skipped when other jobs are skipped - needs to actually pass the list of required jobs through to the workflow
Like this:
The fact that those were missing means this workflow has probably never worked in this repo and it's been doing a full run of CI on every commit 🙃
Just pushed 20c564e fixing that.
There was a problem hiding this comment.
Thank you @jameslamb, I always assumed it was designed by default
|
/merge |
Description
Follow-up to changes for rapidsai/build-planning#241
rapids-init-pipfeature flags now that those have become the default behavior (Revert "rapids-init-pip: add a migrator for removing pypi.nvidia.com (#241)" rapidsai/gha-tools#242)Summary by CodeRabbit