Skip to content

remove pip.conf migration code in CI scripts, fix pr-builder configuration#821

Merged
rapids-bot[bot] merged 5 commits intoNVIDIA:mainfrom
jameslamb:rapids-init-pip-updates
Feb 4, 2026
Merged

remove pip.conf migration code in CI scripts, fix pr-builder configuration#821
rapids-bot[bot] merged 5 commits intoNVIDIA:mainfrom
jameslamb:rapids-init-pip-updates

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Feb 2, 2026

Description

Follow-up to changes for rapidsai/build-planning#241

Summary by CodeRabbit

  • Chores
    • Simplified CI build and test initialization by removing several explicit environment overrides so dependency setup now relies on default behavior.
    • CI pull-request builder step now runs unconditionally and forwards full job context to invoked workflows, improving consistency of PR builds.

@jameslamb jameslamb added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Feb 2, 2026
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 2, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb jameslamb added non-breaking Introduces a non-breaking change and removed non-breaking Introduces a non-breaking change labels Feb 2, 2026
@jameslamb jameslamb changed the title WIP: remove pip.conf migration code in CI scripts remove pip.conf migration code in CI scripts Feb 2, 2026
@jameslamb jameslamb marked this pull request as ready for review February 2, 2026 20:51
@jameslamb jameslamb requested a review from a team as a code owner February 2, 2026 20:51
@jameslamb jameslamb requested a review from AyodeAwe February 2, 2026 20:51
@coderabbitai
Copy link

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Removed explicit initialization and export of the RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX environment variable from multiple CI build/test scripts; updated PR workflow step to run unconditionally and forward the full needs object to the invoked workflow.

Changes

Cohort / File(s) Summary
Build Wheel Scripts
ci/build_wheel.sh, ci/build_wheel_cuopt.sh, ci/build_wheel_cuopt_mps_parser.sh, ci/build_wheel_cuopt_server.sh, ci/build_wheel_cuopt_sh_client.sh, ci/build_wheel_libcuopt.sh
Removed the two-line initialization and export of RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true" in each script; no other logic changes.
Test Scripts
ci/test_self_hosted_service.sh, ci/test_wheel_cuopt.sh, ci/test_wheel_cuopt_server.sh
Removed the two-line initialization and export of RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true" in each script; no other logic changes.
Workflow
.github/workflows/pr.yaml
Added always: true to the pr-builder step and forwarded the full needs object via with.needs: ${{ toJSON(needs) }}.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: removing pip.conf migration code from CI scripts and fixing pr-builder configuration, matching the file changes shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bdice
Copy link
Contributor

bdice commented Feb 3, 2026

/merge

source rapids-configure-sccache
source rapids-date-string
RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX="true"
export RAPIDS_INIT_PIP_REMOVE_NVIDIA_INDEX
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just picking an arbitrary place on the diff to re-post this comment, so follow-ups can be grouped together in a thread.

hmmmm I'm not really sure why this isn't mergeable. pr-builder / run is getting skipped:

image

https://github.com/NVIDIA/cuopt/actions/runs/21615281140/job/62369023603?pr=821

I tried manually re-running it and it was skipped again.

Maybe the changes from #805 and/or this PR have left it in a weird state? I'll investigate. It shouldn't be the case that things like docs-build being skipped cause the entire pr-builder run to be skipped.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, there's a GitHub outage affecting status checks: https://www.githubstatus.com/incidents/f314nlctbfs5

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub say they've pushed a fix but re-running the pr-builder job, it still showed as skipped. I've just fully re-run all CI on this PR... it's possible that other status checks from earlier jobs were lost during the incident or something.

If that still fails, I'll investigate whether there's something else going on here, maybe unrelated to that GitHub incident.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jobs getting skipped should be no problem for pr-builder:

https://github.com/rapidsai/shared-workflows/blob/ce125aca3e92a02adb84a78f7361424bc08ee62c/.github/workflows/pr-builder.yaml#L20

I haven't seen this problem in any other repo using that. My theories right now are either that this PR was in a weird state because of the GitHub incident related to statuses today, or that some of this custom stuff done in this repo is confusing the check:

check-lean-ci:

prevent-merge-with-lean-ci:

compute-matrix-filters:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! I see the problem!

pr-builder is misconfigured here:

  • needs an if: always() to ensure it isn't skipped when other jobs are skipped
  • needs to actually pass the list of required jobs through to the workflow

Like this:

https://github.com/rapidsai/cudf/blob/b978750d0af8ddb20f4112fdbd6936e49297eafc/.github/workflows/pr.yaml#L47-L49

The fact that those were missing means this workflow has probably never worked in this repo and it's been doing a full run of CI on every commit 🙃

Just pushed 20c564e fixing that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jameslamb, I always assumed it was designed by default

@KyleFromNVIDIA
Copy link
Member

/merge

@jameslamb jameslamb removed the request for review from AyodeAwe February 3, 2026 19:20
@jameslamb jameslamb changed the title remove pip.conf migration code in CI scripts remove pip.conf migration code in CI scripts, fix pr-builder configuration Feb 4, 2026
@rapids-bot rapids-bot bot merged commit abaa34b into NVIDIA:main Feb 4, 2026
92 checks passed
@jameslamb jameslamb deleted the rapids-init-pip-updates branch February 4, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants