Skip to content

chore(keyring-controller): replace Sinon with Jest mocks#7965

Merged
cryptodev-2s merged 1 commit intomainfrom
chore/keyring-controller-replace-sinon-with-jest
Feb 18, 2026
Merged

chore(keyring-controller): replace Sinon with Jest mocks#7965
cryptodev-2s merged 1 commit intomainfrom
chore/keyring-controller-replace-sinon-with-jest

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Feb 17, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Test-only mocking changes and devDependency removal; no production logic is modified.

Overview
Removes sinon from @metamask/keyring-controller and migrates the remaining Sinon-based assertions/stubs in KeyringController.test.ts to Jest equivalents (jest.fn, toHaveBeenCalled*, jest.spyOn(...).mockRejectedValue).

This is a test-only refactor plus dependency cleanup (including yarn.lock), with no runtime behavior changes to the controller itself.

Written by Cursor Bugbot for commit 8ba1c7f. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s requested review from a team as code owners February 17, 2026 21:24
@cryptodev-2s cryptodev-2s self-assigned this Feb 17, 2026
@cryptodev-2s cryptodev-2s changed the title chore(keyring-controller): replace Sinon with Jest mocks chore(keyring-controller): replace Sinon with Jest mocks Feb 17, 2026
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 4eb5e7d Feb 18, 2026
308 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/keyring-controller-replace-sinon-with-jest branch February 18, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants