chore(keyring-controller): replace Sinon with Jest mocks#7965
Merged
cryptodev-2s merged 1 commit intomainfrom Feb 18, 2026
Merged
chore(keyring-controller): replace Sinon with Jest mocks#7965cryptodev-2s merged 1 commit intomainfrom
Sinon with Jest mocks#7965cryptodev-2s merged 1 commit intomainfrom
Conversation
Sinon with Jest mocks
Mrtenz
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Low Risk
Test-only mocking changes and devDependency removal; no production logic is modified.
Overview
Removes
sinonfrom@metamask/keyring-controllerand migrates the remaining Sinon-based assertions/stubs inKeyringController.test.tsto Jest equivalents (jest.fn,toHaveBeenCalled*,jest.spyOn(...).mockRejectedValue).This is a test-only refactor plus dependency cleanup (including
yarn.lock), with no runtime behavior changes to the controller itself.Written by Cursor Bugbot for commit 8ba1c7f. This will update automatically on new commits. Configure here.