fix: ZstdCodec with sharding
#56
Merged
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`zstd` would try end decode the entire shard instead of a subchunk. The added test fails without the patch with: `ZarrV3Test.testShardingWithZstdCodecReadWrite:225 » Zstd Destination buffer is too small`
brokkoli71
approved these changes
Feb 9, 2026
Member
brokkoli71
left a comment
brokkoli71
left a comment
There was a problem hiding this comment.
Good catch! I think the problem is, that the underlying array that is returned with .array() contains the whole shard, right? I think it makes sense to check for other ByteBuffer.array() calls that could raise a similar problem. I can do that in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zstdwould try end decode the entire shard instead of a subchunk. The added test fails without the patch with:ZarrV3Test.testShardingWithZstdCodecReadWrite:225 » Zstd Destination buffer is too small