Open
Conversation
bestander
suggested changes
Aug 9, 2017
|
|
||
| # Detailed design | ||
|
|
||
| As a first step, the existing implementation for *hosted* git dependencies should be removed, and patterns that previously matched a hosted dependency should resolve to a git repository. |
Member
There was a problem hiding this comment.
Could you justify why the code for hosted git dependencies should be removed?
Are there specific issues caused by the current implementation?
Can it be just modified?
| - a fallback git repository url (to be used if previous urls are not accessible, for example permission issue) | ||
|
|
||
| The `Git` utility should be the only place to make a distinction between *hosted* repositories and other repositories.\ | ||
| If it is a *hosted* repository, the `Git` utility should first try to make HTTPS requests, then fallback on using the `git` command. |
Member
There was a problem hiding this comment.
Could you add some examples for the workflow?
The most important part of this RFC is to identify the rules for hosted/regular git dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rendered RFC
I was previously trying to make a PR related to these changes, but it was becoming too big. There are still several unresolved questions.