Skip to content

Fix newly reported PHPStan errors#147

Merged
swissspidy merged 1 commit intomainfrom
fix-phpstan
Feb 13, 2026
Merged

Fix newly reported PHPStan errors#147
swissspidy merged 1 commit intomainfrom
fix-phpstan

Conversation

@swissspidy
Copy link
Member

No description provided.

@swissspidy swissspidy added this to the 2.3.3 milestone Feb 13, 2026
@swissspidy swissspidy requested a review from a team as a code owner February 13, 2026 08:55
@swissspidy swissspidy added the scope:testing Related to testing label Feb 13, 2026
Copilot AI review requested due to automatic review settings February 13, 2026 08:55
@github-actions
Copy link
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@gemini-code-assist
Copy link

Summary of Changes

Hello @swissspidy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code quality and compatibility by addressing newly reported PHPStan errors. It includes an update to a core WP-CLI dependency and introduces more precise type hinting and type casting within the UnfilteredPlugin class. These changes improve static analysis checks and ensure better type safety, contributing to a more robust codebase.

Highlights

  • Dependency Update: The wp-cli/wp-cli dependency has been updated to version ^2.13 in composer.json.
  • PHPDoc Enhancements: Improved type hinting for the UnfilteredPlugin class by adding an @extends annotation and refining the return type for the get method.
  • Type Safety: Added explicit type casting for the $name parameter within the get method of UnfilteredPlugin to ensure string type consistency.
Changelog
  • composer.json
    • Updated the wp-cli/wp-cli dependency from ^2.12 to ^2.13.
  • src/WP_CLI/Fetchers/UnfilteredPlugin.php
    • Added @extends PHPDoc annotation to the UnfilteredPlugin class for improved type hinting.
    • Refined the return type PHPDoc for the get method to specify the exact object structure.
    • Introduced explicit type casting for the $name parameter in the get method to ensure string type.
Activity
  • No activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves PHPStan errors by enhancing type safety. The changes introduce more specific PHPDoc annotations in UnfilteredPlugin and add an explicit type cast, which are good practices. The update to the wp-cli/wp-cli dependency is also appropriate. Overall, these changes improve code quality and maintainability, and I approve them.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses newly reported PHPStan issues by tightening type information around the plugin fetcher and aligning the package’s WP-CLI dependency with the version expected by the updated static analysis assumptions.

Changes:

  • Add PHPStan generics/shape annotations for UnfilteredPlugin and refine its get() return type.
  • Normalize the $name input to a string before comparisons to satisfy stricter static analysis.
  • Bump the required wp-cli/wp-cli version constraint from ^2.12 to ^2.13.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/WP_CLI/Fetchers/UnfilteredPlugin.php Adds PHPStan type annotations and normalizes input type to reduce static analysis errors.
composer.json Updates the minimum WP-CLI dependency version used by this package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy merged commit 023da3b into main Feb 13, 2026
63 checks passed
@swissspidy swissspidy deleted the fix-phpstan branch February 13, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant