Merged
Conversation
Contributor
gasbytes
commented
Mar 2, 2026
- fix for report from fuzzers (+ regression test for it);
- m-241 from f. (+ regression test for it)
…gression test for it
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes checksum handling for odd-length ICMP payloads and hardens TCP input validation to prevent malformed IP length handling, with regression tests covering both cases.
Changes:
- Add odd-length tail-byte handling to ICMP checksum calculation.
- Add
ip.lenminimum-header-length validation intcp_input()to avoid invalid subtraction/processing. - Add unit/regression tests for odd-length ICMP echo reply checksum and TCP
ip.len < IP_HEADER_LEN.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/wolfip.c | Fixes ICMP checksum computation for odd lengths and adds TCP IP length validation guard. |
| src/test/unit/unit.c | Adds regression tests for the above ICMP and TCP fixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielinux
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.