Skip to content

Allow OTA upgrade between ESP32_V4 and ESP32 release names#5407

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/allow-upgrade-to-esp32
Draft

Allow OTA upgrade between ESP32_V4 and ESP32 release names#5407
Copilot wants to merge 2 commits intomainfrom
copilot/allow-upgrade-to-esp32

Conversation

Copy link
Contributor

Copilot AI commented Mar 6, 2026

The OTA compatibility check performs exact string matching on release names, which prevents upgrading between ESP32_V4 (IDF v4 builds) and ESP32 (newer IDF builds) even though they target identical hardware.

Changes

  • wled00/wled_metadata.cpp
    • Added normalizeReleaseName() helper that strips a trailing _V4 suffix before comparison
    • Updated shouldAllowOTA() to fall back to normalized name comparison when exact match fails — OTA is allowed if normalized names match, blocked otherwise
"ESP32"    ↔ "ESP32_V4"    → allowed
"ESP32_8M" ↔ "ESP32_8M_V4" → allowed (generalizes to all _V4 variants)
"ESP32"    ↔ "ESP8266"     → blocked (different hardware, unaffected)
Original prompt

This section details on the original issue you should resolve

<issue_title>Upgrade from ESP32_V4 to ESP32 should be allowed</issue_title>
<issue_description>The OTA upgrade check should have an exception to allow swapping between these two different release names</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: netmindz <442066+netmindz@users.noreply.github.com>
Copilot AI changed the title [WIP] Allow upgrade from ESP32_V4 to ESP32 Allow OTA upgrade between ESP32_V4 and ESP32 release names Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade from ESP32_V4 to ESP32 should be allowed

2 participants