Skip to content

i18n(es): update multiple files#241

Merged
Adammatthiesen merged 1 commit intomainfrom
es-up-10
Mar 11, 2026
Merged

i18n(es): update multiple files#241
Adammatthiesen merged 1 commit intomainfrom
es-up-10

Conversation

@dreyfus92
Copy link
Member

@dreyfus92 dreyfus92 commented Mar 10, 2026

Description

  • What does this PR change? Give us a brief description.
    Updates multiple files

Summary by CodeRabbit

  • Documentation
    • Updated Spanish language documentation with native HTML5 video playback instead of external video components
    • Simplified plugin configuration examples by removing version requirement metadata
    • Updated icon reference format in plugin dashboard examples

@dreyfus92 dreyfus92 requested a review from a team as a code owner March 10, 2026 21:21
@htg-1-studiocms-cloud
Copy link

htg-1-studiocms-cloud bot commented Mar 10, 2026

Dokploy Preview Deployment

Name Status Preview Updated (UTC)
StudioCMS Docs ✅ Done Preview URL 2026-03-10T21:26:00.342Z

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

📝 Walkthrough

Walkthrough

The pull request removes the studiocmsMinimumVersion property from plugin documentation examples and the StudioCMSPlugin interface definition, updates a dashboard grid icon reference format, replaces a Youtube component with native HTML5 video, and applies minor formatting adjustments to Spanish documentation.

Changes

Cohort / File(s) Summary
Plugin Documentation Updates
src/content/docs/es/plugins/index.mdx, src/content/docs/es/plugins/extended.mdx, src/content/docs/es/plugins/renderers.mdx
Removed studiocmsMinimumVersion property from StudioCMSPlugin interface definition and all plugin example code blocks. Updated dashboard grid icon reference from 'bolt' to 'heroicons:bolt' in extended plugin example.
Component & Media Updates
src/content/docs/es/index.mdx
Replaced Youtube component with native HTML5 video element featuring autoplay, loop, muted, playsinline, and preload attributes.
Formatting
src/content/docs/es/guides/index.mdx
Cosmetic line reflow in the "Bases de Datos" section without content modifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

Suggested reviewers

  • Adammatthiesen
  • RATIU5
  • louisescher

Poem

🐰 Version fields fade away, icons shine bright anew,
HTML5 videos play where components once grew,
Spanish docs now cleaner, examples refined and lean,
A rabbit hops through the docs—best changes we've seen! 🎬

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title "i18n(es): update multiple files" is vague and overly broad, using non-descriptive language that doesn't convey the specific nature of the changes. Consider a more descriptive title that highlights the main change, such as "i18n(es): remove studiocmsMinimumVersion property and update plugin configurations" or similar that captures the primary modifications.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch es-up-10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@studiocms-no-reply
Copy link
Member

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
es/guides/index.mdx Localization changed, will be marked as complete.
es/index.mdx Localization changed, will be marked as complete.
es/plugins/extended.mdx Localization changed, will be marked as complete.
es/plugins/index.mdx Localization changed, will be marked as complete.
es/plugins/renderers.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/content/docs/es/index.mdx`:
- Line 31: The <video> element currently uses autoplay and loop with no controls
(attributes: autoplay, loop, muted), which prevents users from stopping motion;
update that <video> tag to either add the controls attribute (preferred) so
users can pause/play and expose native controls, or remove autoplay and/or loop
if you want it to be static; optionally add an accessible alternative like a
visible play/pause button with an aria-label if custom controls are needed —
make this change on the existing <video> element in the file.

In `@src/content/docs/es/plugins/index.mdx`:
- Line 20: Remove all stale prose references to studiocmsMinimumVersion: delete
it from the "required-properties" list and remove the paragraph that states it
is mandatory so the documentation matches the current interface and the
definePlugin() example; search for the symbol studiocmsMinimumVersion and update
the sections around the header "El tipo de complemento de StudioCMS", the
required-properties list, and the paragraph near the definePlugin() example
(lines referenced in the review) to eliminate any mention that it is required.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 832dc187-0f67-4c37-8c26-c040021aab29

📥 Commits

Reviewing files that changed from the base of the PR and between 02ebf80 and 02c5c13.

📒 Files selected for processing (5)
  • src/content/docs/es/guides/index.mdx
  • src/content/docs/es/index.mdx
  • src/content/docs/es/plugins/extended.mdx
  • src/content/docs/es/plugins/index.mdx
  • src/content/docs/es/plugins/renderers.mdx
💤 Files with no reviewable changes (1)
  • src/content/docs/es/plugins/renderers.mdx

@Adammatthiesen Adammatthiesen merged commit 6b2e577 into main Mar 11, 2026
8 checks passed
@Adammatthiesen Adammatthiesen deleted the es-up-10 branch March 11, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants