icon and menu fixed#19
Open
LastKing wants to merge 1 commit intowillklein:masterfrom
LastKing:future/fixedMenu
Open
icon and menu fixed#19LastKing wants to merge 1 commit intowillklein:masterfrom LastKing:future/fixedMenu
LastKing wants to merge 1 commit intowillklein:masterfrom
LastKing:future/fixedMenu
Conversation
Owner
|
Thank you for the pull request! Let me take a look and test in a few browsers. I might make some changes to what you submitted, but I'll try to merge this if it works, and make other changes after merging. 😄 |
willklein
reviewed
Apr 17, 2019
| markdownTarget.innerHTML += link; | ||
| } | ||
| var link = '<span class="github-markdown-contents select-menu js-menu-container js-select-menu"><span class="github-markdown-contents-btn js-select-menu js-menu-target btn btn-sm tooltipped-s' + '" role="button" aria-label="Show Table of Contents">' + threeBarSvg + '</span>' + | ||
| '<div class="select-menu-modal-holder github-markdown-contents-modal-holder js-menu-content js-navigation-container" style="width:300px;left:-100px;top:20px;">' + |
Owner
There was a problem hiding this comment.
Thank you for making this multiple lines!
willklein
reviewed
Apr 17, 2019
| }; | ||
|
|
||
| var insertContents = function(contents) { | ||
| var insertContents = function (contents) { |
Owner
There was a problem hiding this comment.
After this pull request I'll setup Prettier so this auto-formats consistently going forward.
Author
There was a problem hiding this comment.
ok，My code is idea format .
It's different from your way.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am English is poor.
Some modifications
fixed icon and menu
this is view.
tanks!
!