Don't break elements created before the polyfill#629
Open
KTibow wants to merge 1 commit intowebcomponents:masterfrom
Open
Don't break elements created before the polyfill#629KTibow wants to merge 1 commit intowebcomponents:masterfrom
KTibow wants to merge 1 commit intowebcomponents:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, if the polyfill is the second thing ran, it breaks all elements created before then with the error "Illegal constructor (custom element class must be registered with global customElements registry to be newable)". If you use bundlers like Rollup, Rollup may have just decided to move the polyfill down, breaking your code as a result. Not anymore.
This PR makes classes extended from raw HTMLElement initialize like they were extended from raw HTMLElement, fixing the issue. Would appreciate getting a release out soon, I'm building something with this polyfill.
*Maybe the polyfill should also do other things like relaying
customElements.getto the native custom elements registry... not sure, that's for later discussion