Skip to content

feat[vortex-runend]: handle canonicalizing Ree<Dict> and Ree<Utf8>#6788

Open
asubiotto wants to merge 1 commit intodevelopfrom
asubiotto/ree
Open

feat[vortex-runend]: handle canonicalizing Ree<Dict> and Ree<Utf8>#6788
asubiotto wants to merge 1 commit intodevelopfrom
asubiotto/ree

Conversation

@asubiotto
Copy link
Contributor

This allows writing these kinds of types. I'm unaware of the motivation behind restricting ree values to just primitive and bool prior to this commit.

Summary

The motivation for this PR is that I want to write RunEndArrays with these value types.

Testing

Unit tests for each new canonicalization path.

@asubiotto asubiotto requested a review from joseph-isaacs March 4, 2026 21:25
@asubiotto asubiotto added the changelog/feature A new feature label Mar 4, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 4, 2026

Merging this PR will not alter performance

✅ 980 untouched benchmarks
⏩ 1466 skipped benchmarks1


Comparing asubiotto/ree (bf6eda1) with develop (c361a3a)2

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (a332796) during the generation of this report, so c361a3a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@asubiotto asubiotto force-pushed the asubiotto/ree branch 2 times, most recently from babb3a9 to 63f27a5 Compare March 4, 2026 21:39
This allows writing these kinds of types. I'm unaware of the motivation behind
restricting ree values to just primitive and bool prior to this commit.

Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
@asubiotto
Copy link
Contributor Author

asubiotto commented Mar 5, 2026

Removed the dict arm since it was unnecessary and inverting the order of canonicalization (causing the benchmark regressions). The existing code already works for dicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant