feat[vortex-runend]: handle canonicalizing Ree<Dict> and Ree<Utf8>#6788
Open
feat[vortex-runend]: handle canonicalizing Ree<Dict> and Ree<Utf8>#6788
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
babb3a9 to
63f27a5
Compare
This allows writing these kinds of types. I'm unaware of the motivation behind restricting ree values to just primitive and bool prior to this commit. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
Contributor
Author
|
Removed the dict arm since it was unnecessary and inverting the order of canonicalization (causing the benchmark regressions). The existing code already works for dicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows writing these kinds of types. I'm unaware of the motivation behind restricting ree values to just primitive and bool prior to this commit.
Summary
The motivation for this PR is that I want to write RunEndArrays with these value types.
Testing
Unit tests for each new canonicalization path.