Skip to content

fix: rename inputs/envs to input/env#225

Merged
branchseer merged 1 commit intomainfrom
claude/rename-envs-inputs-LMexR
Mar 12, 2026
Merged

fix: rename inputs/envs to input/env#225
branchseer merged 1 commit intomainfrom
claude/rename-envs-inputs-LMexR

Conversation

@branchseer
Copy link
Member

This PR standardizes the naming convention for task configuration fields by renaming plural forms to singular forms across the codebase.

Summary

Renamed configuration field names from plural to singular to improve consistency and clarity:

  • inputsinput (for file input patterns in cache configuration)
  • envsenv (for environment variables in cache configuration)

Key Changes

Configuration Schema Updates:

  • Updated EnabledCacheConfig struct fields: envs: Option<Box<[Str]>>env: Option<Box<[Str]>>
  • Updated EnabledCacheConfig struct fields: inputs: Option<UserInputsConfig>input: Option<UserInputsConfig>
  • Updated TypeScript type definitions in run-config.ts to reflect the new field names
  • Updated documentation comment for UserInputEntry to reference input array instead of inputs

Code Updates:

  • Updated all references throughout the codebase to use the new field names
  • Updated test cases and test fixtures to use input and env instead of inputs and envs
  • Updated configuration deserialization and serialization logic
  • Updated default values in UserTaskOptions::default()
  • Updated synthetic task creation in lib.rs and main.rs

Documentation Updates:

  • Updated task-cache.md documentation to reference input and env fields
  • Updated wildcard-env-patterns.md to use env terminology
  • Updated CLAUDE.md reference documentation
  • Updated test snapshot descriptions and comments

Test Fixtures:

  • Updated all vite-task.json fixture files to use input instead of inputs
  • Updated all vite-task.json fixture files to use env instead of envs
  • Updated test snapshot files and descriptions
  • Updated e2e test configuration files

Implementation Details

  • The change is applied consistently across all configuration layers (user config, resolved config, cache metadata)
  • All serde deserialization/serialization updated to handle the new field names
  • Comments and documentation updated to reflect singular naming convention
  • Test names updated to match the new terminology (e.g., test_inputs_*test_input_*)

https://claude.ai/code/session_01565Vu5goEjTJjXVVpvaQnb

Rename the task configuration fields for consistency:
- `envs` → `env`: environment variable names for fingerprinting
- `inputs` → `input`: file patterns for cache fingerprinting

Updated across source code, JSON fixtures, test snapshots, fixture
directory names, test names, documentation, and comments.

https://claude.ai/code/session_01565Vu5goEjTJjXVVpvaQnb
@branchseer branchseer changed the title Rename inputs/envs to input/env for consistency fix: rename inputs/envs to input/env Mar 12, 2026
@branchseer branchseer requested review from cpojer and fengmk2 March 12, 2026 00:41
"cache": true,
"envs": ["NODE_ENV"],
"env": ["NODE_ENV"],
"passThroughEnvs": ["CI"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this?

@branchseer branchseer merged commit c69a26d into main Mar 12, 2026
6 checks passed
@branchseer branchseer deleted the claude/rename-envs-inputs-LMexR branch March 12, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants