Skip to content

Conversation

@Rutpiv
Copy link
Contributor

@Rutpiv Rutpiv commented Dec 30, 2025

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture (x86_64)
  • I built this PR locally for these architectures using specific masterdirs:
    • x86_64-musl
    • i686
  • I built this PR locally for these architectures (crossbuilds):
    • aarch64
    • aarch64-musl
    • armv7l
    • armv7l-musl
    • armv6l
    • armv6l-musl

( cd test/; python3 -m pytest )
}
checksum=3978a25d43d9a7b8a89ae9d726bd4962fc90dc4f69ae852e399f3c56d4b0bd63
make_check=no # tests no longer work.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't they work now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding

checkdepends="python3-pytest"
make_check_pre="env LC_ALL=en_US.UTF-8"

and backporting ahupp/python-magic@545a2a5 and ahupp/python-magic@4ffcd59 makes them work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reached the same conclusion after your first comment.
I identified those upstream commits afterwards, but hadn’t updated the template yet.
I’ll follow your suggestion and update the template accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, the tests were already failing with the previous version as well when built against current libmagic. The changes you suggested make them pass again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, if you can't explain why the tests don't work and justify why they shouldn't be expected to work, they should not be skipped. Disabling tests just because they fail defeats the purpose of our CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re right, and I agree with that guideline. Skipping tests just because they fail isn’t appropriate unless we can clearly justify why they shouldn’t be expected to pass.

In this case I made a wrong assumption based on the tag date (June 7, 2022) and thought there wouldn’t be upstream changes affecting the test expectations without a new release. That turned out to be incorrect: the project did receive relevant upstream fixes without bumping the version, and my initial approach was rushed.

After classabbyamp’s question I took a deeper look and it does seem the failures likely started around the mid-2023 libmagic/file updates, and there are upstream commits addressing exactly this.

Sorry for the trouble.

@ahesford ahesford merged commit 9313e86 into void-linux:master Dec 31, 2025
8 checks passed
@Rutpiv Rutpiv deleted the python3-magic branch December 31, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants