-
Notifications
You must be signed in to change notification settings - Fork 2.5k
python3-magic: update to 0.4.27. #58336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
srcpkgs/python3-magic/template
Outdated
| ( cd test/; python3 -m pytest ) | ||
| } | ||
| checksum=3978a25d43d9a7b8a89ae9d726bd4962fc90dc4f69ae852e399f3c56d4b0bd63 | ||
| make_check=no # tests no longer work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't they work now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding
checkdepends="python3-pytest"
make_check_pre="env LC_ALL=en_US.UTF-8"and backporting ahupp/python-magic@545a2a5 and ahupp/python-magic@4ffcd59 makes them work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reached the same conclusion after your first comment.
I identified those upstream commits afterwards, but hadn’t updated the template yet.
I’ll follow your suggestion and update the template accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, the tests were already failing with the previous version as well when built against current libmagic. The changes you suggested make them pass again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, if you can't explain why the tests don't work and justify why they shouldn't be expected to work, they should not be skipped. Disabling tests just because they fail defeats the purpose of our CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You’re right, and I agree with that guideline. Skipping tests just because they fail isn’t appropriate unless we can clearly justify why they shouldn’t be expected to pass.
In this case I made a wrong assumption based on the tag date (June 7, 2022) and thought there wouldn’t be upstream changes affecting the test expectations without a new release. That turned out to be incorrect: the project did receive relevant upstream fixes without bumping the version, and my initial approach was rushed.
After classabbyamp’s question I took a deeper look and it does seem the failures likely started around the mid-2023 libmagic/file updates, and there are upstream commits addressing exactly this.
Sorry for the trouble.
96dfa2a to
8caa244
Compare
Testing the changes
Local build testing