Open
Conversation
bluwy
reviewed
Mar 11, 2026
| fsp.readFile(cachePath, 'utf8'), | ||
| ]) | ||
|
|
||
| if (Date.now() - stat.ctime.valueOf() > 30 * 24 * 60 * 60 * 1000) { |
Member
There was a problem hiding this comment.
The default 30 days is also being used here to check its cache validity. It's think we might need to use import { X509Certificate } from 'node:crypto' to parse the cert and refactor this part to read the validity there instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #97
Adds a new optional parameter to allow the expiration date of the certificate to be customized past the default 30 days.
Happy to rename the parameter if there's a better name that we could use.