-
Notifications
You must be signed in to change notification settings - Fork 141
Update docs template #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update docs template #552
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (11 failed)mongodb (1 failed):
redis (1 failed):
starter (8 failed):
turso (1 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
❌ Some E2E test jobs failed:
Check the workflow run for details. |
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 10 parallel steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express stress test: Promise.all with 100 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express stress test: Promise.race with 100 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Suggestion:
The app's URL structure has changed to use language-prefixed routes (/[lang]/docs/), but the redirects in next.config.ts still point to the old non-language-prefixed routes, causing these redirects to fail and return 404 errors.
View Details
📝 Patch Details
diff --git a/docs/next.config.ts b/docs/next.config.ts
index 9f8856f..878306e 100644
--- a/docs/next.config.ts
+++ b/docs/next.config.ts
@@ -49,12 +49,12 @@ const config: NextConfig = {
return [
{
source: '/docs',
- destination: '/docs/getting-started',
+ destination: '/en/docs/getting-started',
permanent: true,
},
{
source: '/err/:slug',
- destination: '/docs/errors/:slug',
+ destination: '/en/docs/errors/:slug',
permanent: true,
},
];
Analysis
Broken redirects in next.config.ts point to non-existent routes
What fails: The redirects in docs/next.config.ts lines 51-52 and 56-58 point to non-language-prefixed routes that don't exist in the application's new language-based routing structure.
How to reproduce:
- Visit
http://localhost:3000/docs- will redirect to/docs/getting-startedwhich returns 404 - Visit
http://localhost:3000/err/serialization-failed- will redirect to/docs/errors/serialization-failedwhich returns 404
Result: Both redirects fail because the app's route structure requires language prefixes (/[lang]/docs/...) but the redirect destinations are missing the language segment.
Expected: The redirects should point to valid language-prefixed routes that exist in the application (e.g., /en/docs/getting-started and /en/docs/errors/:slug).
Root cause: The application migrated to language-based routing (/[lang]/docs/...) with dynamic language segments, but the redirects in next.config.ts were not updated to include the language prefix. Since /docs/... routes no longer exist and /[lang] is a required dynamic segment, the redirect destinations result in 404 errors.
Fix applied: Updated redirect destinations to use the default language 'en' as prefix:
/docs→/en/docs/getting-started/err/:slug→/en/docs/errors/:slug
Uh oh!
There was an error while loading. Please reload this page.