fix(chmod): report Permission denied instead of No such file or directory #9860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Author
|
The CI failure on This test was previously skipped on the This looks like a flaky test or CI infrastructure issue rather than a regression caused by this PR. All 41 existing chmod tests pass locally and the new test case validates the fix correctly. Would it be possible to re-run the CI or have a maintainer take a look at why this unrelated test started running? |
Contributor
|
Could you please fix the conflict? Thanks |
…tory When a file exists but is inaccessible due to permission restrictions, chmod was incorrectly reporting "No such file or directory" because Path::exists() returns false for both non-existent files and inaccessible files. This change uses fs::metadata() to distinguish between these two cases and reports the appropriate error message based on the actual error kind (PermissionDenied vs NotFound). Fixes uutils#9789 Signed-off-by: majiayu000 <[email protected]>
majiayu000
force-pushed
the
fix/chmod-permission-denied-error-message
branch
from
76c83d0 to
b15beab
Compare
Author
|
Rebased onto main and resolved the conflict. Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fs::metadata()instead ofPath::exists()to distinguish between "file doesn't exist" and "permission denied" errorsRoot Cause
When a file exists but is inaccessible due to permission restrictions (e.g.,
chmod 755 locked/filewherelockeddirectory has no permissions),Path::exists()returnsfalsefor both non-existent files and inaccessible files. This caused chmod to incorrectly report "No such file or directory" instead of "Permission denied".Changes
Chmoder::chmod()to usefs::metadata()and check the error kindtest_chmod_permission_denied_not_no_such_fileto verify correct behaviorTest plan
Fixes #9789