Skip to content

mv: Use rustc-hash#11010

Open
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:mv-fx
Open

mv: Use rustc-hash#11010
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:mv-fx

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Feb 18, 2026

No description provided.

@oech3
Copy link
Contributor Author

oech3 commented Feb 18, 2026

mv_multiple_to_dir
+2% 12.6 ms -> 12.3 ms

mv_force_overwrite
0% 142 ms -> 141.9 ms

Is mv bounded by I/O perf too?

@oech3 oech3 force-pushed the mv-fx branch 2 times, most recently from a0b2b3f to 6934263 Compare February 18, 2026 12:27
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/date/date-locale-hour. tests/date/date-locale-hour is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tail/truncate. tests/tail/truncate is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cut/bounded-memory is no longer failing!
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

// remember the moved destinations for further usage
let mut moved_destinations: HashSet<PathBuf> = HashSet::with_capacity(files.len());
let mut moved_destinations: FxHashSet<PathBuf> =
FxHashSet::with_capacity_and_hasher(files.len(), rustc_hash::FxBuildHasher);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying we can't use FxHashSet::with_capacity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can open an issue at https://github.com/rust-lang/rustc-hash . (also .with_capacity_auto()?)

@oech3 oech3 force-pushed the mv-fx branch 2 times, most recently from 5bb6648 to de7325d Compare February 18, 2026 13:42
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cut/bounded-memory is no longer failing!
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 18, 2026

Merging this PR will not alter performance

✅ 69 untouched benchmarks
⏩ 257 skipped benchmarks1


Comparing oech3:mv-fx (ed00cec) with main (ce08ea0)

Open in CodSpeed

Footnotes

  1. 257 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 marked this pull request as ready for review February 18, 2026 14:16
path = "src/mv.rs"

[dependencies]
rustc-hash = { workspace = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: alphabetize

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does not CI detect this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use taplo to lint .toml files. I don't know if this is a supported feature.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cut/bounded-memory. tests/cut/bounded-memory is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/cp/link-heap is now being skipped but was previously passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments