mv: use GNU default error when overwriting non-empty directory#10078
Open
aaron-ang wants to merge 1 commit intouutils:mainfrom
Open
mv: use GNU default error when overwriting non-empty directory#10078aaron-ang wants to merge 1 commit intouutils:mainfrom
aaron-ang wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
Contributor
Author
|
#10435 should fix the CI errors. |
|
GNU testsuite comparison: |
Contributor
Author
|
hi @sylvestre, could you please take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5102.
The GNU default
mverror message:cannot overwrite {target}: Directory not empty, is clear enough for the case of overwriting non-empty directory. It clearly states the overwrite intent and thattargetis the empty directory.Our current message:
cannot move {source} to {target}: Directory not empty, is causing confusion (see #5102 (comment)) and should be reverted.In addition, I made test cases stricter by expecting stderr only and replaced some comments with full expected errors.