Refactor 28 generic s3 #45
Conversation
Meldiron
left a comment
Meldiron
left a comment
There was a problem hiding this comment.
LGTM, tiny code-quality improvements.
Let's also try to implement one test using a Generic adapter. It can connect to the same providers as we use, but it would use Generic, instead of a specific adapter.
src/Storage/Device/BackBlaze.php
Outdated
| namespace Utopia\Storage\Device; | ||
|
|
||
| use Utopia\Storage\Device\S3; | ||
| use Utopia\Storage\Device\Generic; |
There was a problem hiding this comment.
We should have a better name for Generic?
Can we use S3 as base instead of creating new Generic?
There was a problem hiding this comment.
S3 is also one of Generic child's.
Can be S3Base? or S3Compatible
There was a problem hiding this comment.
What's the difference in S3 itself and Generic? if there is a difference then yes Generic can S3Base - S3Base sounds more reasonable than S3Compatible.
Co-authored-by: Matej Bačo <[email protected]>
…ctor-28-genericS3
lohanidamodar
left a comment
lohanidamodar
left a comment
There was a problem hiding this comment.
Looks much better.
|
@christyjacob4, is this still needed? |
No description provided.