Skip to content

Conversation

@loks0n
Copy link
Contributor

@loks0n loks0n commented Nov 12, 2025

Summary by CodeRabbit

  • New Features
    • Configurable request and connection timeouts added to all logging adapters.
    • You can now specify custom connection timeout and overall request timeout when initializing logging.
    • Improves control over network behavior and increases reliability of log delivery across varying network conditions.

@coderabbitai
Copy link

coderabbitai bot commented Nov 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds configurable timeout handling to four logger adapters (AppSignal, LogOwl, Raygun, Sentry). Each adapter now defines private default timeout/connect-timeout constants, two protected properties ($timeout, $connectTimeout), and extended constructors that accept optional timeout and connectTimeout parameters (normalizing non‑positive values to defaults). The adapters apply the configured values to CURL via CURLOPT_TIMEOUT and CURLOPT_CONNECTTIMEOUT. AppSignal, Raygun, and Sentry introduce defaults of 5s and a 1s connect timeout; LogOwl also adds default timeout/connect-timeout constants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify consistent validation/normalization for timeout and connectTimeout across all adapters.
  • Confirm CURLOPT_TIMEOUT and CURLOPT_CONNECTTIMEOUT are applied where cURL is used and values are properly typed.
  • Check constructor signature changes for backward compatibility and search for call sites that may need updating.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: timeouts' directly and clearly summarizes the main change: adding configurable timeout parameters to multiple logger adapter classes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0ead2e and 34a935d.

📒 Files selected for processing (4)
  • src/Logger/Adapter/AppSignal.php (2 hunks)
  • src/Logger/Adapter/LogOwl.php (2 hunks)
  • src/Logger/Adapter/Raygun.php (2 hunks)
  • src/Logger/Adapter/Sentry.php (4 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.


class LogOwl extends Adapter
{
private const DEFAULT_TIMEOUT = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its 3 here but 5 for others?

@loks0n loks0n merged commit b19cf23 into main Nov 12, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants