Feat: Honeybadger adaptor #19
Conversation
|
The test fails due to the unavailability of the honeybadger API key🙂 |
|
Thank you so much for the PR 🤩. We're adding the |
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Great PR! 🤯 We left some comments during the review, please check them out.
|
@2002Bishwajeet please address the comments |
|
Sample generated from test case:
|
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Small change please! 🙏🏼
|
@stnguyen90 , I did some work on #24. Request for re-review |
|
@2002Bishwajeet thanks a lot for your contributions during Hacktoberfest 2022! Please address fix the failing tests so we can move forward with this. Meanwhile you can reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. |
|
Updated changes |
|
Also while running static code analysis, I get this Not sure if it means success or not |
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Looks like there are some lint errors.
| foreach ($breadcrumbsObject as $breadcrumb) { | ||
| \array_push($breadcrumbsArray, [ | ||
| 'category' => $breadcrumb->getCategory(), | ||
| 'timestamp' => \intval($breadcrumb->getTimestamp()), |
There was a problem hiding this comment.
I tested this recently, but got an error in Honeybadger because they expect this to be a string like 2020-01-27T12:37:31.616-08:00. Would you please update this to be a ISO-8601 formatted timestamp in UTC?
4 participants
What it does
Fixes #4212
Miscellaneous Changes
add-logger-adaptor.mdTesting
Manual Testing
Have you read the contributing guidelines?
Always 😉