Don't throw on deleteAttribute if column doesn't exist #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnegate
reviewed
Nov 7, 2024
Member
abnegate
left a comment
abnegate
left a comment
There was a problem hiding this comment.
Let's add a test to make sure this works as expected
abnegate
reviewed
Nov 7, 2024
abnegate
reviewed
Nov 8, 2024
abnegate
reviewed
Nov 8, 2024
abnegate
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that when you deleteAttributes, if the column for the attribute does not exist, the adapter will still return true so the metadata can be cleaned up appropriately. Tests are not included for this as replicating the environment for this isn't easy with the tests architecture we have